incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From J├╝rgen Schmidt <jogischm...@googlemail.com>
Subject Re: [PATCH] Fix for #118485#, #108221#, #67705#
Date Thu, 13 Oct 2011 13:00:27 GMT
On Wed, Oct 12, 2011 at 5:47 PM, Pedro Giffuni <pfg@apache.org> wrote:

> Hi;
>
> --- On Wed, 10/12/11, Armin Le Grand <Armin.Le.Grand@me.com> wrote:
>
> >     Hi Pedro,
> >
> > On 12.10.2011 03:43, Pedro Giffuni wrote:
> > > Hi;
> > >
> > > I committed it as revision 1182166, and noted it in
> > > the bug report, but I admit the patch was too big to do
> > > a review on it.
> >
> > Thanks for comitting. I think - as i wrote - for someone
> > knowing the  core it would have been possible to read the
> > diffs. This is not too big from my POV, I have bigger
> > changes in the pipeline.
> >
>
> Oh yes, it was not that big, but it touched a lot of files
> which made it difficult to get the context. In any case
> big patches are sometimes necessary and I was confident
> this wouldn't go bad: it was my way of saying "this guy
> should be a committer so he can fix the stuff he breaks"
> :),
>
>
+1

Juergen

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message