incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Regina Henschel <rb.hensc...@t-online.de>
Subject Re: [PATCH] Fix for #118485#, #108221#, #67705#
Date Thu, 27 Oct 2011 17:46:11 GMT
Hi Armin,


Armin Le Grand schrieb:
> Hi Regina,
>
> On 25.10.2011 18:33, Regina Henschel wrote:
>> Hi Armin,
>>
>> Armin Le Grand schrieb:
>> [..]
>>> I checked all changes again and added the patch to #118485#. Now I'm
>>> looking for someone volunteering to add the patch, build AOOo and play
>>> around with OLEs a little bit, reading the patch will also help in this
>>> case, it's not too big to do so.
>>
>> I did some further tests.
>
> Good, go ahead :-)
>
> Have You checked the converters?

No, I have not known, that they are possible now too.

  It's even possible to convert charts
> directly to Sdr-3D-Objects (but not nice) :-) You can directly substract
> e.g. an ellipse from a chart, too.

So I have to do some additional tests.

>
> In activated mode there should be no rot/shear and no green handles
> anymore (was an error anyways, modifying these while the OLE was
> activated leaded to unpredictable errors).  Changing dimensions of the
> activated OLE will adapt to the centered OLE after deactivation as needed.

I have updated my build and see the improvements :)

[..]

>>
>> Documents made with LibreOffice are not converted. The background is
>> blue and the line black. Is a solution possible inside AOOo? Should it
>> be done?
>
> Source of this is that LO already has 3.4 version and the correction
> would have to be done for LO <= 3.4, plus writing OLEs with LINE_NONE
> and FILL_NONE if set (activating LineProperties/FillProperties for OLEs
> in LO, too). I'm already in contact with Thorsten and we are working on
> a solution for both together. I need to check if LO files can be
> detected and it looks like being possible. ODF exchange is very
> important for all of us, so there should be a correction in AOO at
> LO-created-file load time and mentioned corrections in LO, too.
>
> As described above, seen from ODF, OLEs are actually blue8 and hairline,
> so technically it's correctly displayed. Some other product using ODF
> FileFormat may have written such files where the OLEs are actually blue8
> and hairline, so correction can only be done for known cases, e.g. OOo <
> 3.4 and LO <= 3.4 where we know for sure that the error was that the old
> paints just ignored LineStyle/FillStyle.
>
> I'm working on it with Thorsten, it's solvable...

That sounds great. I'm looking forward to the result of your teamwork.

>
>> I have written a Basic macro to set the background and line style to
>> NONE. Developing it I have noticed, that the Math-objects do not support
>> the services LineProperties and FillProperties. But I can set the single
>> properties 'LineStyle' and 'FillStyle' and Xray lists all the other
>> properties. So shouldn't they support these services?
>
> Not sure. StarMath is a regular OLE, so it should support LineProperties
> and FillProperties. But not inside StarMath itself, it's supported in
> the SdrObject containing the StarMath. There may be exceptions in the
> old code for StarMath. It's also possible that You used it in Writer
> which has it's own OLE implementation and does not (yet) support those
> new features...?

I have used it in Draw and I'm on the OLE-object not on the StarMath 
model. The chart-object has the same problem. I have attached a document 
containing macros. Select 1 object and call TestService from module 
'Diagnose' in Library 'RepairFormulas'.

Kind regards
Regina

Mime
View raw message