incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Giffuni <...@apache.org>
Subject Re: [CODE] gtk system tray icon and libegg
Date Fri, 07 Oct 2011 14:56:29 GMT
Hello ariel;

--- On Thu, 10/6/11, Ariel Constenla-Haile <ariel.constenla.haile@gmail.com> wrote:
...
> Hi there,
> 
> the GTK system tray is broken:
> 
> 1) ENABLE_QUICKSTART_APPLET is not defined, so
> ShutdownIcon::IsQuickstarterInstalled()
>    returns false, instead of trying to load
> libqstart_gtk.so
>    http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sfx2/source/appl/shutdownicon.cxx?view=markup#l769
> 
> 2) ENABLE_SYSTRAY_GTK is not defined, so the plugin library
> name is not
>    defined
>    http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sfx2/source/appl/shutdownicon.cxx?view=markup#l96
>    http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sfx2/source/appl/shutdownicon.cxx?view=markup#l159
> 
> 3) the library name should be modified, due to changes in
> the DLLPOSTFIX;
>    and should not be a string, because it is
> stringified (or PLUGIN_NAME
>    could be defined in the Makefile)
> 
> 4) the GTK system tray depends on libegg, a LGPL v2+
> library. Quite
>    strange the library is build but not
> installed. This causes that the
>    libqstart_gtk.so cannot be loaded.
>    libegg is copy-left, so it should be
> replaced by GtkStatusIcon
>    (requires at most gtk 2.16)
>    http://developer.gnome.org/gtk/2.24/GtkStatusIcon.html
>    This looks like an easy task.
> 

FWIW, libegg is indeed something we have to get rid of, not
only due to the license issue but because it looks like it's
deprecated: the code was made part of gtk and has been
changing a lot since then. I looks like the code we have is
not available independently so using the functionality in
GTK is the way to go.

> 5) trunk/main/sfx2/source/appl/shutdowniconunx.cxx has no
> license header. Is this file in the software
> grant? 
>    Looking at the hg log, it comes from:
> 
> changeset:   174966:ddd13100457e
> user:        kz
> date:        Fri Oct 06 10:39:32 2006
> +0000
> files:   
>    sfx2/source/appl/shutdowniconunx.cxx
> description:
> INTEGRATION: CWS gtkquickstart (1.1.2); FILE ADDED
> 2006/08/01 10:59:27 mmeeks 1.1.2.2: Issue number: i#57872#
> Submitted by: mmeeks
> Warning fixes.
> 2006/08/01 10:57:04 mmeeks 1.1.2.1: #i57872#
> gtk systray quickstarter
> 
> https://issues.apache.org/ooo/show_bug.cgi?id=57872
> first comment says something about JCAs, but I don't get
> it.
>

My guess is that mmeeks signed a JCA for his code and
was even willing to get a JCA for libegg too. His code
should be covered by the grant but I have no idea what
the lawyers will do since there is no copyright header
(probably just be conservative and say no).
There is an initial grant already but I forgot where it
is.

> Attached patch solves (1) and (2) but is useless until
> knowing the status of (5) and then fixing (4).
>

I think a patch for (4) would be the way to go. I am in
no position to review your patches for (1) and (2),
hopefully someone else can.

Thanks for the research!

Pedro.

Mime
View raw message