incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis E. Hamilton" <dennis.hamil...@acm.org>
Subject RE: [PATCH] Fix for #118485#, #108221#, #67705#
Date Sun, 16 Oct 2011 20:39:32 GMT
While attention is on the topic of rendering control for OLE objects,
I have questions:

How does this modification show up in the ODF XML surrounding the
OLE object (element <draw:ole-object>)?  

In addition Also, one problem that has been a source of complaint is
failure to preserve cropping of the rendering of an OLE object. Is
that covered also?

 - Dennis

-----Original Message-----
From: Regina Henschel [mailto:rb.henschel@t-online.de] 
Sent: Sunday, October 16, 2011 12:58
To: ooo-dev@incubator.apache.org
Subject: Re: [PATCH] Fix for #118485#, #108221#, #67705#

Hi Armin,

Armin Le Grand schrieb:
> Hi *,
>
> I took some days to fix that long missing OLE-Attribute feature/bug. It
> is on one hand a missing feature (no reason to not apply attributes and
> transformations to OLE which contains the same as graphical object, a
> MetaFile) and on the other a compatibility issue with a big competitor
> which is able to add attributes to OLEs for a long time.
>
> This fix was already prepared in #67705# but could not be activated due
> to a missing part of #108221#. Thanks to ORW (aka Oliver-Rainer) which
> helped to solve that.
>
> The patch adds LineStyle, FillStyle, Text, Shadow, Shear and Rotate to
> OLE objects in Draw/Impress and Calc. It adds Shear to graphic objects.
> It also fixes some long existing not detected bugs to make all this
> work. It leaves OLEs and graphical objects for Writer (SW) untouched due
> to the fact that SW uses it's own implementations for those (one more
> argument for the long missing consolidation in SW to use DrawingLayer
> objects for this).

[..]
>
> I checked all changes again and added the patch to #118485#. Now I'm
> looking for someone volunteering to add the patch, build AOOo and play
> around with OLEs a little bit, reading the patch will also help in this
> case, it's not too big to do so.

I played a bit around, you know I'm happy to try out new things.

Take a Draw-document.
Insert a default chart.
Rotate the chart 90°.
Set chart to edit mode.
Drag the grey edge to change the size of the chart.
Leave edit mode.
Notice, the chart jumps to top of page.
Expected behavior: Resize is done centered to old position or relative 
to the opposite site of the dragged one.

Take a Impress-document.
Insert a default chart.
Rotate the chart 90°.
Switch to presentation mode.
Notice the chart has the size of the rotated one, but is not rotated but 
scaled to fit the rotated size.
(People might want to rotate charts in presentations, because a combined 
bar-line chart is not available but only a combined column-line chart.)

Kind regards
Regina


Mime
View raw message