incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Giffuni <giffu...@tutopia.com>
Subject Re: svn commit: r1172617 - /incubator/ooo/trunk/main/solenv/bin/build.pl
Date Tue, 20 Sep 2011 01:12:21 GMT
 You guys have just reminded me of codespell, a pretty nice tool
 to find english mistakes and typos in code comments:

 http://git.profusion.mobi/cgit.cgi/lucas/codespell/

 Cheers,

 Pedro.

 On Mon, 19 Sep 2011 19:22:43 -0400, TJ Frazier <tjfrazier@cfl.rr.com> 
 wrote:
> On 9/19/2011 09:33, hdu@apache.org wrote:
>> Author: hdu
>> Date: Mon Sep 19 13:33:24 2011
>> New Revision: 1172617
>>
>> URL: http://svn.apache.org/viewvc?rev=1172617&view=rev
>> Log:
>> prolongue is not in my dictionary
>>
>> Modified:
>>      incubator/ooo/trunk/main/solenv/bin/build.pl
>>
>> Modified: incubator/ooo/trunk/main/solenv/bin/build.pl
>> URL: 
>> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/solenv/bin/build.pl?rev=1172617&r1=1172616&r2=1172617&view=diff
>> 
>> ==============================================================================
>> --- incubator/ooo/trunk/main/solenv/bin/build.pl (original)
>> +++ incubator/ooo/trunk/main/solenv/bin/build.pl Mon Sep 19 13:33:24 
>> 2011
>> @@ -1694,7 +1694,10 @@ sub cancel_build {
>>           foreach (keys %broken_build) {
>>               print STDERR "ERROR: error " . $broken_build{$_} . " 
>> occurred while making $_\n";
>>           };
>> -        print STDERR "\nAttention: if you fix the errors in above 
>> module(s) you may prolongue your the build issuing command:\n\n\t" . 
>> $message_part;
>> +#        print STDERR "\nAttention: when you fixed the errors in 
>> these module(s) you can resume the build by issuing the 
>> command:\n\n\t" . $message_part;
>> +        print STDERR "\nWhen you fixed the errors in " .
>> +		(length(@broken_module_names)==1 ? "that module" : "these 
>> modules") .
>> +		" you can resume the build by running:\n\n\t" . $message_part;
>>       } else {
>>           while (children_number()) {
>>               handle_dead_children(1);
>>
>>
>>
>>
> Thank you very much for fixing that ugly error. For the best English,
> after "When you" in both places, you should either s/fixed/fix/ or
> s/fixed/have fixed/ to get the tense right.


Mime
View raw message