incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Stahl <...@openoffice.org>
Subject Re: svn commit: r1162609 - in /incubator/ooo/trunk/main: autodoc/inc/ary/idl/ basegfx/source/polygon/ chart2/source/controller/main/ dbaccess/source/core/dataaccess/ hwpfilter/source/ libwpd/ moz/ moz/patches/ sc/source/filter/inc/
Date Mon, 29 Aug 2011 08:39:12 GMT
On 29.08.2011 02:27, Eike Rathke wrote:
> Hi Michael,
> 
> On Sunday, 2011-08-28 23:23:03 -0000, mst@apache.org wrote:
> 
>> URL: http://svn.apache.org/viewvc?rev=1162609&view=rev
> 
>> --- incubator/ooo/trunk/main/autodoc/inc/ary/idl/i_ce2s.hxx (original)
>> +++ incubator/ooo/trunk/main/autodoc/inc/ary/idl/i_ce2s.hxx Sun Aug 28 23:23:03 2011
>> @@ -50,6 +50,7 @@ class Ce_2s
>>  {
>>    public:
>>      // LIFECYCLE
>> +    explicit Ce_2s () { }
>>      virtual             ~Ce_2s();
>>  
>>      static DYN Ce_2s *  Create_(
> 
> I took a different approach without introducing that ctor:
> https://svn.apache.org/viewvc/incubator/ooo/trunk/main/autodoc/source/ary/idl/i_ce.cxx?r1=1162288&r2=1162554&pathrev=1162554&diff_format=h
> 
> IMHO holding a const dummy just to be able to return a const reference
> if the factory didn't yet create an instance is nonsense.

indeed you are right; i just failed to remove this from the patch that i
had laying around for weeks (and i had not actually looked at the use
site back then which indeed was nonsense).


Mime
View raw message