incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mathias Bauer <Mathias_Ba...@gmx.net>
Subject Re: svn commit: r1162610 - in /incubator/ooo/trunk/main: binfilter/bf_sfx2/source/doc/ binfilter/bf_starmath/source/ binfilter/bf_svtools/source/misc/ chart2/source/view/main/ slideshow/source/engine/shapes/ svtools/source/misc/ unotools/inc/unotools/
Date Mon, 29 Aug 2011 07:36:29 GMT
On 29.08.2011 02:36, Eike Rathke wrote:
> Hi Michael,
>
> On Sunday, 2011-08-28 23:34:31 -0000, mst@apache.org wrote:
>
>> URL: http://svn.apache.org/viewvc?rev=1162610&view=rev
>> Log:
>> unotools: OOutputStreamWrapper:
>>
>>   remove invocation of DECLARE_UNO3_AGG_DEFAULTS
>>   (symbols are somehow not exported with GCC 4.6, and it seems to be
>>   unnecessary)
>
> The "somehow" may be related to the -fPIC vs -fpic I mentioned in an
> earlier mail. Simply removing the DECLARE_UNO3_AGG_DEFAULTS(...) removes
> forwarding of acquire() and release() calls to the baseclass, I don't
> think that's correct. See comphelper/inc/comphelper/uno3.hxx

Is it wise to fix the code for gcc 4.6 *now*? Every fix might introduce 
new bugs and gcc 4.6 is not the "standard" compiler nowadays (AFAIK).

Regards,
Mathias

Mime
View raw message