incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis E. Hamilton" <dennis.hamil...@acm.org>
Subject RE: [PATCH] Corrected two typos on website
Date Sat, 25 Jun 2011 14:53:54 GMT
It's true, if an e-mail sender injects hard line wraps, it screws up the patch.  (In the past,
this has been a problem if you digitally sign the mail using the MIME signature technique.
 I haven't checked if that is still the case.)

I have no idea why Notepad++ would change the eol convention on Windows.  Maybe it just left
the breaks in the way they came out of TortoiseSVN DIFF, if that was used to make the Patch.

I know the regular Notepad, which is the default for opening a .txt attachment on my machine,
pukes pretty badly on the attachment that was sent. (I know, I know, I will see how to change
that application association to something more robust.)

The key thing is that attachments don't receive inter-platform EOL adjustment -- the mail
clients don't (or shouldn't) touch them.



-----Original Message-----
From: Greg Stein [mailto:gstein@gmail.com] 
Sent: Saturday, June 25, 2011 04:37
To: ooo-dev@incubator.apache.org
Subject: Re: [PATCH] Corrected two typos on website

On Jun 25, 2011 5:58 AM, "Dick Groskamp" <th.groskamp@quicknet.nl> wrote:
>
> Op 24-6-2011 23:39, Dennis E. Hamilton schreef:
>
>> It helps if patches are in-line in the mail note.  (That way, EOL
differences are compensated for and those of us with an MS-DOS mentality
don't have to save the attachment to disk to find a way to view it
correctly.)
>>
>>  - Dennis
>>
>> PS: I guess I should find a way to change my default *.txt viewer to one
that is agnostic about EOL conventions, but the one I prefer takes too long
to fire up.
>
> OK,  but, being the tech illaterate that I am, that seems to be a
contradiction of this page:
> http://www.apache.org/dev/contributors.html#svnbasics
> stating
> "Some projects don't use an issue tracker. In that case, send the patch as
an attachment to an e-mail with a subject prefixed with "[PATCH]". Patches
should be sent to the appropriate development mailing list."
>
> Just trying to get it clear. I don't mind to put it in-line nor to attach
it.
> It makes hardly any difference to me.
>
> Or is it dependent on the text-editor I am using (Notepad++ in this case)?

Just to throw further fuel on the fire....

Inline patches (not attachments) are sometimes subject to line-wrap, which
*totally* screws them up.

What fun :-)

Cheers,
-g

ps. thus, git was created as a fancy patch-manager :-)


Mime
View raw message