incubator-ooo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhan...@apache.org
Subject svn commit: r1356537 - /incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
Date Tue, 03 Jul 2012 01:35:40 GMT
Author: zhangjf
Date: Tue Jul  3 01:35:39 2012
New Revision: 1356537

URL: http://svn.apache.org/viewvc?rev=1356537&view=rev
Log:
#120078# add virtual destructor to WW8 resource model base classes to avoid memory leak, includes
Value, Properties, Table ... 
Found by: zhangjf
Patch by: zhangjf

Modified:
    incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx

Modified: incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx?rev=1356537&r1=1356536&r2=1356537&view=diff
==============================================================================
--- incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx (original)
+++ incubator/ooo/trunk/main/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx Tue Jul 
3 01:35:39 2012
@@ -138,6 +138,7 @@ public:
     */
     virtual void sprm(Sprm & sprm) = 0;
     
+    virtual ~Properties(){}
 };
 
 /**
@@ -154,6 +155,8 @@ public:
        @param ref     reference to properties of the entry
      */
     virtual void entry(int pos, writerfilter::Reference<Properties>::Pointer_t ref)
= 0;    
+
+    virtual ~Table() {}
 };
 
 /**
@@ -171,6 +174,8 @@ public:
      */
     virtual void data(const sal_uInt8* buf, size_t len,
                       writerfilter::Reference<Properties>::Pointer_t ref) = 0;
+
+    virtual ~BinaryObj(){}
 };
 
 /**
@@ -271,6 +276,8 @@ public:
        @param info     the information
      */
     virtual void info(const string & info) = 0;
+
+    virtual ~Stream() {}
 };
 
 /**
@@ -322,6 +329,8 @@ public:
        Returns string representation of this value.
      */
     virtual string toString() const = 0;
+
+    virtual ~Value() {}
 };
 
 /**
@@ -373,6 +382,8 @@ public:
        Returns string repesentation of sprm.
      */
     virtual string toString() const = 0;
+
+    virtual ~Sprm() {}
 };
 
 /**



Mime
View raw message