incubator-ooo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a..@apache.org
Subject svn commit: r1344156 - in /incubator/ooo/trunk/main/svx: inc/svx/unoshape.hxx source/unodraw/unoshap4.cxx
Date Wed, 30 May 2012 08:56:18 GMT
Author: alg
Date: Wed May 30 08:56:17 2012
New Revision: 1344156

URL: http://svn.apache.org/viewvc?rev=1344156&view=rev
Log:
#119337# Solves the wrong get/setPropertyValue calls in SvxShapeText (and thus in SvxOle2Shape)

Modified:
    incubator/ooo/trunk/main/svx/inc/svx/unoshape.hxx
    incubator/ooo/trunk/main/svx/source/unodraw/unoshap4.cxx

Modified: incubator/ooo/trunk/main/svx/inc/svx/unoshape.hxx
URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/svx/inc/svx/unoshape.hxx?rev=1344156&r1=1344155&r2=1344156&view=diff
==============================================================================
--- incubator/ooo/trunk/main/svx/inc/svx/unoshape.hxx (original)
+++ incubator/ooo/trunk/main/svx/inc/svx/unoshape.hxx Wed May 30 08:56:17 2012
@@ -339,9 +339,6 @@ protected:
 	virtual void unlock();
 
 protected:
-    using SvxUnoTextRangeBase::setPropertyValue;
-    using SvxUnoTextRangeBase::getPropertyValue;
-
 	// overide these for special property handling in subcasses. Return true if property is
handled
     virtual bool setPropertyValueImpl( const ::rtl::OUString& rName, const SfxItemPropertySimpleEntry*
pProperty, const ::com::sun::star::uno::Any& rValue ) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::beans::PropertyVetoException, ::com::sun::star::lang::IllegalArgumentException,
::com::sun::star::lang::WrappedTargetException, ::com::sun::star::uno::RuntimeException);
     virtual bool getPropertyValueImpl( const ::rtl::OUString& rName, const SfxItemPropertySimpleEntry*
pProperty, ::com::sun::star::uno::Any& rValue ) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::lang::WrappedTargetException, ::com::sun::star::uno::RuntimeException);

Modified: incubator/ooo/trunk/main/svx/source/unodraw/unoshap4.cxx
URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/svx/source/unodraw/unoshap4.cxx?rev=1344156&r1=1344155&r2=1344156&view=diff
==============================================================================
--- incubator/ooo/trunk/main/svx/source/unodraw/unoshap4.cxx (original)
+++ incubator/ooo/trunk/main/svx/source/unodraw/unoshap4.cxx Wed May 30 08:56:17 2012
@@ -467,7 +467,7 @@ sal_Bool SvxOle2Shape::createObject( con
     ::comphelper::IEmbeddedHelper*     pPersist = mpModel->GetPersist();
     ::rtl::OUString              aPersistName;
     OUString            aTmpStr;
-	if( getPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME ) ) >>=
aTmpStr )
+	if( SvxShape::getPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME ) )
>>= aTmpStr )
         aPersistName = aTmpStr;
 
     //TODO/LATER: how to cope with creation failure?!
@@ -498,7 +498,7 @@ sal_Bool SvxOle2Shape::createObject( con
         }
 
 		// connect the object after the visual area is set
-        setPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME ), Any( aTmpStr
= aPersistName ) );
+        SvxShape::setPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME
), Any( aTmpStr = aPersistName ) );
 
 		// the object is inserted during setting of PersistName property usually
 		if( pOle2Obj->IsEmpty() )
@@ -561,7 +561,7 @@ sal_Bool SvxOle2Shape::createLink( const
         }
 
 		// connect the object after the visual area is set
-        setPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME ), uno::makeAny(
aPersistName ) );
+        SvxShape::setPropertyValue( OUString::createFromAscii( UNO_NAME_OLE2_PERSISTNAME
), uno::makeAny( aPersistName ) );
 
 		// the object is inserted during setting of PersistName property usually
 		if ( pOle2Obj->IsEmpty() )



Mime
View raw message