Mailing-List: contact oodt-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oodt-dev@incubator.apache.org
Message-ID: <19631482.157571290024614821.JavaMail.jira@thor>
Date: Wed, 17 Nov 2010 15:10:14 -0500 (EST)
From: "Chris A. Mattmann (JIRA)" <jira@apache.org>
To: oodt-commits@incubator.apache.org
Subject: [jira] Commented: (OODT-61) appendTableName property for mapping
 files in XMLPS breaks columnname-based lookup in ResultSet
In-Reply-To: <30337174.156291290022214195.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OODT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933123#action_12933123 ] 

Chris A. Mattmann commented on OODT-61:
---------------------------------------

Hey Dave:

I'd favor using option #2 here. Also we should add a unit test to detect this going forward, something to the effect of actually cooking up a base xmlps.xml conf file with fields of the same name from different tables and then testing that the SQL produced is correct, and that there is no exception when trying to read the field names.


> appendTableName property for mapping files in XMLPS breaks columnname-based lookup in ResultSet
> -----------------------------------------------------------------------------------------------
>
>                 Key: OODT-61
>                 URL: https://issues.apache.org/jira/browse/OODT-61
>             Project: OODT
>          Issue Type: Bug
>          Components: xmlps
>    Affects Versions: 0.1-incubating
>         Environment: Mac OS X 10.6, Java SDK 6, Tomcat 7, connecting to SQL Server and Oracle databases.
>            Reporter: Dave Kale
>            Assignee: Dave Kale
>             Fix For: 0.2-incubating
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Basically, I introduced a bug when I added the appendTableName property to the map file reading stuff in XMLPS.  The original goal of appendTableName was to help with disambiguation when joining tables with fields that have identical names.  However, the way "appendTableName" is handled right now, XMLPS tries to used the table-appended field name to retrieve results from the ResultSet, producing the following error:
> Nov 17, 2010 10:48:11 AM org.apache.oodt.xmlps.product.DBMSExecutor toCDERow
> WARNING: Unable to obtain field: [TableName.FieldName] from result set: message: Invalid column name
> I propose that we do one of the following:
> 1. Make the simplest fix, which is not use the appended table name when looking up results in the ResultSet.
> 2. Get rid of the appendTableName property and instead make XMLPS handle disambiguation automatically: when it detects fields of the same name from different tables, it automatically appends table name when constructing queries in which the field shows up in the SELECT part of the query.
> 3. Other options?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.