incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Girin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ODFTOOLKIT-388) Test hangs when iterating over a spreadsheet created with LibreOffice 4.0.0
Date Fri, 25 Apr 2014 14:29:17 GMT

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981056#comment-13981056
] 

Bruno Girin commented on ODFTOOLKIT-388:
----------------------------------------

Nick, I agree, the crux is {{table.getCellCoverInfos}}. Having thought it through a bit more,
I also agree that {{Table.getRowCount}} and {{Row.getCellCount}} should not ignore empty cells
or rows. However, it would be useful to provide alternative versions of those methods that
do ignore them, this way the user can choose.

So I would suggest this:
* Fix:
** Make {{table.getCellCoverInfos}} more efficient;
* Non-essential improvements:
** Add {{isEmpty}} methods on {{Cell}} and {{Row}};
** Add variations of {{Table.getRowCount}} and {{Row.getCellCount}} that ignore empty rows
/ cells;
** Add variations of {{Table.getCellByPosition}}, {{Table.getRowByIndex}} and {{Row.getCellByIndex}}
that don't have side effects.

This way the API behaviour doesn't change and it offers more flexibility to client code. I'm
happy to specify those in additional tasks and work on them to provide patches.

> Test hangs when iterating over a spreadsheet created with LibreOffice 4.0.0
> ---------------------------------------------------------------------------
>
>                 Key: ODFTOOLKIT-388
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-388
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: simple api
>    Affects Versions: 0.6-incubating, 0.6.1-incubating
>            Reporter: Bruno Girin
>         Attachments: SpreadsheetDocumentTest.java, saxProblem.ods, simple.ods, toolkit.patch
>
>
> When iterating over a simple spreadsheet created with LibreOffice 4, the code hangs on
Row.getCellCount().
> Running the same document through the validator at http://odf-validator.rhcloud.com/
confirms that it is conformant to ODF1.2:
> {quote}
> The document is conformant ODF1.2!
> Details:
> simple.ods: Info: ODF version of root document: 1.2
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-manifest-schema.rng: Info: parsed.
> simple.ods/META-INF/manifest.xml: Info: no errors, no warnings
> simple.ods/mimetype: Info: no errors, no warnings
> simple.ods: Info: Media Type: application/vnd.oasis.opendocument.spreadsheet
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-schema.rng: Info: parsed.
> simple.ods/meta.xml: Info: Generator: LibreOffice/4.0.2.2$Linux_X86_64 LibreOffice_project/400m0$Build-2
> simple.ods/meta.xml: Info: no errors, no warnings
> simple.ods/settings.xml: Info: no errors, no warnings
> simple.ods/styles.xml: Info: no errors, no warnings
> simple.ods/content.xml: Info: no errors, no warnings
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-dsig-schema.rng: Info: parsed.
> simple.ods: Info: no errors, no warnings
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message