incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Evans (JIRA)" <>
Subject [jira] [Commented] (ODFTOOLKIT-388) Test hangs when iterating over a spreadsheet created with LibreOffice 4.0.0
Date Fri, 25 Apr 2014 09:47:17 GMT


Nick Evans commented on ODFTOOLKIT-388:

Bruno, I have just spent some time looking through the ODF code based on your analysis.  I
think you identify some interesting points:
# The call to {{table.getCellCoverInfos}} means that calculating the number of cells in a
row involves interating over the entire table!  This seems to be because a cell in the row
could potentially be covered by any other cell in the table (although as you point out, only
actually by cells with lower row and column indices.)
# {{table.getCellCoverInfos}} causes a cascade of other expensive calls (for instance getRowByIndex)

I also agree that the solution to this problem is not at all obvious:
# I think ignoring empty rows in a spreadsheet is not an option because there are many cases
when one might be interested in empty rows.
# The crux of the problem lies in {{getCellCoverInfos}}.  Perhaps the implementation of this
function could be made more efficient with a more dedicated solution rather than delegating
to other expensive methods and without side effects?

> Test hangs when iterating over a spreadsheet created with LibreOffice 4.0.0
> ---------------------------------------------------------------------------
>                 Key: ODFTOOLKIT-388
>                 URL:
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: simple api
>    Affects Versions: 0.6-incubating, 0.6.1-incubating
>            Reporter: Bruno Girin
>         Attachments:, saxProblem.ods, simple.ods, toolkit.patch
> When iterating over a simple spreadsheet created with LibreOffice 4, the code hangs on
> Running the same document through the validator at
confirms that it is conformant to ODF1.2:
> {quote}
> The document is conformant ODF1.2!
> Details:
> simple.ods: Info: ODF version of root document: 1.2
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-manifest-schema.rng: Info: parsed.
> simple.ods/META-INF/manifest.xml: Info: no errors, no warnings
> simple.ods/mimetype: Info: no errors, no warnings
> simple.ods: Info: Media Type: application/vnd.oasis.opendocument.spreadsheet
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-schema.rng: Info: parsed.
> simple.ods/meta.xml: Info: Generator: LibreOffice/$Linux_X86_64 LibreOffice_project/400m0$Build-2
> simple.ods/meta.xml: Info: no errors, no warnings
> simple.ods/settings.xml: Info: no errors, no warnings
> simple.ods/styles.xml: Info: no errors, no warnings
> simple.ods/content.xml: Info: no errors, no warnings
> internal:/schema/odf1.2/OpenDocument-v1.2-cos01-dsig-schema.rng: Info: parsed.
> simple.ods: Info: no errors, no warnings
> {quote}

This message was sent by Atlassian JIRA

View raw message