incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dali Liu <wawal...@gmail.com>
Subject Re: [Call-For-Review] ODFToolkit-351 issues of TextSelection.replaceWith() methods
Date Thu, 07 Feb 2013 09:46:58 GMT
Hi kejia,

Great job, I will review the codes and commit it tomorrow.

2013/2/7 Kejia Ye <christie.ykj@gmail.com>

> I just uploaded a patch to fix the issues 1-5 mentioned in
> ODFTOOLKIT-351<https://issues.apache.org/jira/browse/ODFTOOLKIT-351>
> .
>
> There's a special task for issue #1 which may not been pointed out clearly.
> It means when the replaced text is in a paragraph with a page break, the
> break settings should be kept after the replacement and no additional page
> breaks are introduced.
>
> To fix this issue in replaceWithTable method, I add a new class
> TableProperties.java and some new APIs to get/set the properties like
> fo:break-before and text:page-number.
>
> New test cases for the new APIs and regression tests for these reported
> bugs are also uploaded. Please help to review, any comments are welcomed.
>  Thanks!
>
> Regard,
> Ke Jia
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message