From odf-dev-return-1140-apmail-incubator-odf-dev-archive=incubator.apache.org@incubator.apache.org Wed Sep 19 11:48:14 2012 Return-Path: X-Original-To: apmail-incubator-odf-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-odf-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BCFDDDE0 for ; Wed, 19 Sep 2012 11:48:14 +0000 (UTC) Received: (qmail 85870 invoked by uid 500); 19 Sep 2012 11:48:14 -0000 Delivered-To: apmail-incubator-odf-dev-archive@incubator.apache.org Received: (qmail 85777 invoked by uid 500); 19 Sep 2012 11:48:13 -0000 Mailing-List: contact odf-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: odf-dev@incubator.apache.org Delivered-To: mailing list odf-dev@incubator.apache.org Received: (qmail 85763 invoked by uid 99); 19 Sep 2012 11:48:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2012 11:48:13 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of svante.schubert@gmail.com designates 209.85.214.47 as permitted sender) Received: from [209.85.214.47] (HELO mail-bk0-f47.google.com) (209.85.214.47) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2012 11:48:04 +0000 Received: by bkvi18 with SMTP id i18so173846bkv.6 for ; Wed, 19 Sep 2012 04:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Mb/wshc7KTXcgQbk+rI6XWE2yOQXoB/dt1qnfFFWP3A=; b=UwXjqA+lGgGGvDp+ddC4s+G7VZLxQlRGkmZOB69tZpQNa7kWvX6E1gvUb/iOc+cbrc frm57Jm3Y+o9a/Lz+CpXZWQ71x4NtVOJ9NvMr0WcGphDWD4CvHRxd6k/M3OvwJks7e9c d4ISB26d1+FvHvuvb85pk5EI+o7tWAf698RoFBkv1GSNuc2M4KdW1Gunml/GNcPKsR0B aYucGWy/yKHV3cOboKTFSWWk1gjFd9Qh4cKIaQenxjXtDqFAleIdXSQgfrTEho60JgJ5 FAPmUELDFFiki3z7YjnZtuf0FNlYFSbGxMr8GyjMPqVgGxCLflupk9ofEIroefYWgORC bNoA== Received: by 10.204.5.144 with SMTP id 16mr1075322bkv.128.1348055263902; Wed, 19 Sep 2012 04:47:43 -0700 (PDT) Received: from [192.168.1.125] (235-80.citynet.ftth.internl.net. [92.254.80.235]) by mx.google.com with ESMTPS id y20sm1638175bkv.11.2012.09.19.04.47.42 (version=SSLv3 cipher=OTHER); Wed, 19 Sep 2012 04:47:43 -0700 (PDT) Message-ID: <5059B0DB.6010609@gmail.com> Date: Wed, 19 Sep 2012 13:47:39 +0200 From: Svante Schubert User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: mst@apache.org CC: odf-dev@incubator.apache.org Subject: Re: [PATCH] validator: create jar-with-dependencies that actually runs References: <5059AED2.4020604@gmail.com> In-Reply-To: <5059AED2.4020604@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit One more thing.. I have moved your new configuration file beyond source, according to the Maven example, given at http://maven.apache.org/plugins/maven-assembly-plugin/usage.html The problem with the default manifest, might be solved, when looking deeper into the log "mvn -e -X package > log.txt", but I am running out of time.. PS: As you are already an apache committer, I have used your patch from the mail attachment. I believe the correct way is to take the attachment from an issue, but no time for the mail ping-pong atm.. ;) Thanks for the patch anyway, Svante On 19.09.2012 13:38, Svante Schubert wrote: > Hi Michael, > > I have applied your patches manual, as the merge did not work out well. > If you like even provide GIT patches and/or use github, as we have a git > read-access. > Downside it is only read-only, but I prefer to copy the diff over to a > svn rep. > > Some notes and changes to your patch noted below... > > On 13.09.2012 20:08, Michael Stahl wrote: >> hi all, >> >> i've just had a need for the ODF validator, tried to build it from >> source and failed miserably. using "mvn install" i got some weird JEE >> .war thing, > The WAR thing is the web application you might add to your local tomcat, > glassfish, whatsoever.. > The front-end is included to it. It was meant to run out-of-the-box. > Never tested the command-line, I realized that the manifest is not being > added. Tried it a while and dropped it, due to time constraints now, but > your manifest works (just had to corrected the spelling).. >> a .jar file with the sources (the point of which escapes >> me), and a validator-with-all-dependencies.jar file. the latter looked >> promising until it became apparent that it didn't, uhmmm, include the >> actual validator classes, so it didn't run. >> >> attached is my attempt to fix this; i failed to somehow add extra files >> to the existing "assembly" thing so just copied its definition from the >> maven website and added the target/classes, which seems to work but is >> likely not the best way to do this (please note that i know absolutely >> nothing about maven). > The manifest entry was wrong, I fixed the correct spelling, did you > tested it? > As you have no test case provided you need to test the latest update.. ;) >> one annoyance i have with the maven build is that it appears to download >> the ODF schemas from the OASIS site over and over again on every "mvn >> install", never noticing that they already exist on the filesystem. i >> remember a time when the validator was built with ant when that didn't >> happen. well back then one had to download all schemas once manually >> which is hardly convenient, but subsequent builds were much faster. > That time was before the Apache legal review. > I am annoyed myself, but not enough to fix it. The solution could be to > upload the various schema to the Maven repository as an artifact. > Someone needs to research on that or simply ask on the Maven list for a > solution for that problem. >> also i've noticed the lack of a .gitignore hence the second patch. > Apache is using Subversion as their house version system, but as I use > mainly git myself, I added it, although moved it to root level. >> regards, >> michael >> > Thanks, > Svante