[ https://issues.apache.org/jira/browse/ODFTOOLKIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460139#comment-13460139 ] 

DaLi Liu commented on ODFTOOLKIT-48:
------------------------------------

Verified status of this issue
2.not sure - I am not sure about this issue, maybe still need to be opened
                
> Package Layer: manifest.xml should be provided as DOM, classes should be generated
> ----------------------------------------------------------------------------------
>
>                 Key: ODFTOOLKIT-48
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-48
>             Project: ODF Toolkit
>          Issue Type: Improvement
>          Components: codegen
>    Affects Versions: 0.8
>         Environment: Operating System: All
> Platform: All
>            Reporter: Svante Schubert
>            Assignee: issues
>            Priority: Minor
>             Fix For: 0.8.7
>
>
> By using a DOM implementation for the manifest.xml we can be sure to maintain foreign elements and we would get changes in the schema directly into our sources by generation, using a symmetric design: The two RelaxNG schemas of the ODF 1.2 spec are used for two generations of typed DOM elements.
> Design draft:
> We took this issue already into account when refactoring the class structure, for instance moving OdfElement, OdfAttribue and OdfFileDom from DOM level to base level org.odftoolkit.odfdom.
> There is currently only one namespace being used in the package schema: 'manifest'. The generated classes would all be in the Java package:
> org.odftoolkit.odfdom.pkg.element.manifest.*
> The creation of OdfNamespace needs adaptions, taking as well the PKG layer namespace into account.
> A further problem that is a prerequisite: there are currently two completely independent javacodetemplate.xml files for DOM and PKG layer.
> Unfortunately there is a lot of shared code, we might think to allow some kind of aggregation to load the shared sources from a single file, otherwise we will have in the future errors by code duplications (e.g. fixing only DOM layer, forgetting PKG). Perhaps a simple XML level external entity would be sufficient, see
> http://www.w3.org/TR/REC-xml/#sec-external-ent
> The generation already exist within a comment in the pom.xml to be tested.
> Finally some package layer refactoring will be necessary, last but not least the PKG tests might be improved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira