incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Weir <robw...@apache.org>
Subject Re: [PATCH] validator: create jar-with-dependencies that actually runs
Date Tue, 18 Sep 2012 21:35:40 GMT
On Thu, Sep 13, 2012 at 2:08 PM, Michael Stahl <mst@apache.org> wrote:
>
> hi all,
>
> i've just had a need for the ODF validator, tried to build it from
> source and failed miserably.  using "mvn install" i got some weird JEE
> .war thing, a .jar file with the sources (the point of which escapes
> me), and a validator-with-all-dependencies.jar file.  the latter looked
> promising until it became apparent that it didn't, uhmmm, include the
> actual validator classes, so it didn't run.
>
> attached is my attempt to fix this; i failed to somehow add extra files
> to the existing "assembly" thing so just copied its definition from the
> maven website and added the target/classes, which seems to work but is
> likely not the best way to do this (please note that i know absolutely
> nothing about maven).
>
> one annoyance i have with the maven build is that it appears to download
> the ODF schemas from the OASIS site over and over again on every "mvn
> install", never noticing that they already exist on the filesystem.  i
> remember a time when the validator was built with ant when that didn't
> happen.  well back then one had to download all schemas once manually
> which is hardly convenient, but subsequent builds were much faster.
>

Hi Michael,

I think Svante was looking into uploading the schemas to the Maven
central repository.  Once they are there then they should be cached
like other dependencies.

Previously, with ant, I think we just included the schemas in the
repository.  That is simpler, certainly, but runs into some ASF
license policy issues.  Since the license on the schemas disallows
modification of the schemas it is not considered "open source", so we
cannot store it in our repository.

Btw, thanks for the patch.

-Rob

> also i've noticed the lack of a .gitignore hence the second patch.
>
> regards,
>  michael
>

Mime
View raw message