incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svante Schubert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ODFTOOLKIT-50) [gsoc2012] Add ODF 1.2 RDF metadata support to ODF Toolkit
Date Tue, 14 Aug 2012 19:04:38 GMT

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434394#comment-13434394
] 

Svante Schubert commented on ODFTOOLKIT-50:
-------------------------------------------

Hi Tao,

I have created a github fork at https://github.com/svanteschubert/odftoolkit/tree/RDF-metadata-support
As you already provided me with the 20120814 patch, I have added all to the fork and did some
cosmetic changes:
a) Changed the line ending on all text files to Unix (to be able to test from a VirtualBox
running under Windows)
b) Saved the existing line breaks on the generator pom.xml, but in general all changes are
equal to yours
c) Deleted about a dozen of *.origins~ files. First time I notice them, I do not think they
belong to your patch, but once found, I removed them.
d) Adapted the download URL of the schema to the latest ODF specification. The new schema
has the new information set, only the header and the URL has been changed

What is missing are some fix of yours in regard of two problems found. In the latter the "
" space is not being encoded in the URL, but it worked before therefore it should not be too
hard:
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.789 sec <<< FAILURE!
testGetRDFMetaFromGRDDLXSLT(org.odftoolkit.odfdom.pkg.RDFMetadataTest)  Time elapsed: 1.297
sec  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<2> but was:<1>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:283)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at junit.framework.Assert.assertEquals(Assert.java:130)
	at junit.framework.Assert.assertEquals(Assert.java:136)
	at org.odftoolkit.odfdom.pkg.RDFMetadataTest.testGetRDFMetaFromGRDDLXSLT(RDFMetadataTest.java:85)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at junit.framework.TestCase.runTest(TestCase.java:168)
	at junit.framework.TestCase.runBare(TestCase.java:134)
	at junit.framework.TestResult$1.protect(TestResult.java:110)
	at junit.framework.TestResult.runProtected(TestResult.java:128)
	at junit.framework.TestResult.run(TestResult.java:113)
	at junit.framework.TestCase.run(TestCase.java:124)
	at junit.framework.TestSuite.runTest(TestSuite.java:232)
	at junit.framework.TestSuite.run(TestSuite.java:227)
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:145)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:104)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1017)
	
	
Aug 14, 2012 6:33:52 PM org.odftoolkit.odfdom.pkg.EmbeddedDocumentTest testSaveEmbeddedDocument
INFO: Save file : /C:/work/coding/odftoolkit-20120814-meta-20120814/odfdom/target/test-classes/Object
11_.odc
Aug 14, 2012 6:33:52 PM org.odftoolkit.odfdom.utils.ResourceUtilities getAbsolutePath
SEVERE: null
java.net.URISyntaxException: Illegal character in path at index 90: file:///C:/work/coding/odftoolkit-20120814-meta-20120814/odfdom/target/test-classes/Object
11_.odc
	at java.net.URI$Parser.fail(URI.java:2829)
	at java.net.URI$Parser.checkChars(URI.java:3002)
	at java.net.URI$Parser.parseHierarchical(URI.java:3086)
	at java.net.URI$Parser.parse(URI.java:3034)
	at java.net.URI.<init>(URI.java:595)
	at org.odftoolkit.odfdom.utils.ResourceUtilities.getAbsolutePath(ResourceUtilities.java:59)
	at org.odftoolkit.odfdom.pkg.EmbeddedDocumentTest.testSaveEmbeddedDocument(EmbeddedDocumentTest.java:209)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:145)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:104)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1017)	

PS: Could not add you as a collaborator, your mail was not recogniced by github (sent you
offlist a mail with further details). Perhaps you simply fork from me and make a push request.
We still should add the patches to JIRA as well to avoid Apache Copyright issues.

Good luck! ;)
Svante

                
> [gsoc2012] Add ODF 1.2 RDF metadata support to ODF Toolkit
> ----------------------------------------------------------
>
>                 Key: ODFTOOLKIT-50
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-50
>             Project: ODF Toolkit
>          Issue Type: New Feature
>          Components: generator
>    Affects Versions: 0.7.5
>         Environment: Operating System: All
> Platform: All
>            Reporter: Svante Schubert
>              Labels: gsoc, gsoc2012, mentor
>             Fix For: 0.8.6
>
>         Attachments: grddl_test_patch.txt, odfdom-metadata_20120718.patch, odfdom-metadata_20120722.patch,
odfdom-metadata_20120725.patch, odfdom-metadata_20120729.patch, odfdom-metadata_20120802.patch,
odfdom-metadata_20120806.patch, odfdom-metadata_20120814.patch, patch_20120618.txt, patch_20120710.txt,
patch_20120711.txt, patch.txt, schema2templates-metadata_20120718.patch, schema2templates-metadata_20120806.patch,
test_rdfmeta.odt, test_rdfmeta.odt, test_rdfmeta.odt, test_rdfmeta.odt, test_rdfmeta.odt,
test_rdfmeta.odt
>
>
> This is one of the greatest features for ODF 1.2 to allow the usage of RDF metadata on
the document and the most important elements. 
> As a co-editor of this spec, I got a special interest in making this feature come alive.
In addition it has a positive side affect to the new OOo API, when scenarios are not even
tested in the office, but as well from a different ODF library.
> Before creating a convenient API, the basic package feature has to be supported.
> Still I believe the usage of an RDF parser is still optional to keep ODFDOM small and
give the user only what he really wants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message