incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svante Schubert (Commented) (JIRA)" <>
Subject [jira] [Commented] (ODFTOOLKIT-312) PATCH: Better exception handling for OdfPackage (swallows IOExceptions on save())
Date Wed, 04 Apr 2012 09:56:22 GMT


Svante Schubert commented on ODFTOOLKIT-312:

Thanks for the patch, I really do like your emulation of "full disc" and "network problems"
of your test case. 
Your enhanced handling by showing IOException to the end user really does improve the ODF
My only adaption were some additional comments to your test.

> PATCH: Better exception handling for OdfPackage (swallows IOExceptions on save())
> ---------------------------------------------------------------------------------
>                 Key: ODFTOOLKIT-312
>                 URL:
>             Project: ODF Toolkit
>          Issue Type: Bug
>          Components: odfdom
>            Reporter: Jeremias Maerki
>            Assignee: Svante Schubert
>              Labels: patch
>         Attachments: OdfPackageExceptionHandling.diff
> Related thread:
> Executive summary: OdfPackage does too much exception catching causing real problems
not being detected by client programs (because the exceptions are only logged). Similar patterns
were observed when reading an ODF package. The attached patch tries to introduce a better
exception handling throughout the OdfPackage class. Instead of throwing Exception, methods
now throw IOException and SAXException. The existing load-side fault tolerance is preserved
but the client can now abort processing if a potentially bad ODF file is read because exceptions
thrown in the ErrorHandlers are no longer swallowed.
> I hope you find the proposed changes useful. They are backed by unit tests. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message