incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Svante Schubert <svante.schub...@gmail.com>
Subject Re: What is wrong with the rat? (earlier: Re: Build failed in Jenkins: ODFToolkit #21)
Date Thu, 01 Mar 2012 10:03:32 GMT
Hi Devin,

it is correct that Oliver was the last one who fixed an issue in this
file, but he only fixed the problem with the versioning numbers, that
caused the build to fail.
If you take a look at the previous commit you had removed the empty text
document from RAT exclusion by deleting the line

<exclude>src/main/resources/examples/odf/odfdom-python/OdfTextDocument.odt</exclude>

from trunk/generator/schema2template/pom.xml take a look at the history.
Was there any reason for doing so? Does "mvn clean install -Ppedantic"
runs smooth on your machine?
If not, please undo your change.

In addition, it seems that "mvn rat:check" does not work from trunk
directory. I guess the exclusion from the trunk/pom.xml will only be
realized when the adequate profile is being called.

PS: How could a remove of the maven repository might change anything?
Was your assumption I had an old rat plugin?
AFAIK pedantic is always downloading the latest references.
For the log, I have been using rat 1.0-alpha3 and I had same results
with last stable version number 8, see
http://search.maven.org/#browse%7C-674558679

Svante

On 01.03.2012 10:21, Devin Han wrote:
> Hi all,
>
> Oliver is the last person modifying the pom.xml for fixing the wrong
> version number.
> @Svante pls clean up or remove your local repository and try again.
>
> 2012/3/1 Svante Schubert <svante.schubert@gmail.com>
>
>> On 29.02.2012 23:17, Rob Weir wrote:
>>> On Wed, Feb 29, 2012 at 4:54 PM, Svante Schubert
>>> <svante.schubert@gmail.com> wrote:
>>>> On 25.02.2012 13:38, Nick Burch wrote:
>>>>> On Fri, 24 Feb 2012, Svante Schubert wrote:
>>>>>> I would suggest to do it similar here. Has anybody further
>>>>>> information on the issue below. Again the apache-rat-plugin triggered
>>>>>> the failure. Similar as in my local build yesterday, but on a
>>>>>> different project.
>>>>> The problem is that someone has added new files, but neglected to add
>>>>> the Apache license header to them:
>>>>>
>>>>>>> mavenExecutionResult exceptions not empty
>>>>>>> message : Failed to execute goal
>>>>>>> org.apache.rat:apache-rat-plugin:0.7:check (default) on project
>>>>>>> odfdom-java: Too many unapproved licenses: 2
>>>>>>> cause : Too many unapproved licenses: 2
>>>>>>> Stack trace :
>>>>>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed
to
>>>>>>> execute goal org.apache.rat:apache-rat-plugin:0.7:check (default)
on
>>>>>>> project odfdom-java: Too many unapproved licenses: 2
>>>>> The license headers should ideally be added by the person who added
>>>>> the file. Could whoever has added new files to svn recently please
>>>>> double check that the headers are there, and add them if not?
>>>>>
>>>>> (To check, run "mvn rat:check" then look for rat.txt files which
>>>>> report the state)
>>>>>
>>>> I just had again a build problems due to RAT failure (on Windows7), but
>>>> I am pretty sure this is not Devin's failure!
>>>> The last nightly build worked fine:
>>>> https://builds.apache.org/job/ODFToolkit/28/
>>>>
>>>> Still in trunk\generator\schema2template\target\rat.txt
>>>> There is a problem of a binary ODF document:
>>>> 1 Unknown Licenses
>>>> *******************************
>>>> Unapproved licenses:
>>>>
>>>>
>> E:/work/coding/odftoolkit-20120229/trunk/generator/schema2template/src/main/resources/examples/odf/odfdom-python/OdfTextDocument.odt
>>>> ...
>>>> !?????
>>>>
>> E:/work/coding/odftoolkit-20120229/trunk/generator/schema2template/src/main/resources/examples/odf/odfdom-python/OdfTextDocument.odt
>>>> This document is part of the initial start-up, the "svn log" shows:
>>>> ------------------------------------------------------------------------
>>>> r1167953 | devin | 2011-08-26 08:21:29 +0200 (Fr, 26 Aug 2011) | 4 lines
>>>>
>>>> changeset:   0:6440405b3f8c
>>>> user:        Svante Schubert <Svante.Schubert@sun.com>
>>>> date:        Mon Jan 11 22:05:39 2010 +0100
>>>> Initial sources to share the maven challenges to master..
>>>> ------------------------------------------------------------------------
>>>>
>>>> What is wrong with RAT?
>>>>
>>> RAT hasn't changed, but the pom has.
>>>
>>> See Revision: 1244419
>>> Author: devinhan
>>> Date: Wednesday, February 15, 2012 4:43:09 AM
>>> Message:
>>> #ODFTOOLKIT-199# Supply signature and manifest features to code
>>> generator plugin.[Developer:Devin]
>>>
>>> There was an exclusion for that ODF file earlier.  The exclusion was
>>> removed.  I don't know why.
>>>
>> Strange, I could not find any configuration options for the rat plugin
>> to declare ODF files as binaries (see
>> http://incubator.apache.org/rat/apache-rat-plugin/usage.html)
>> If this is the reason for the failure, how could the nightly build two
>> days ago pass?
>> Anyway, as long the only vantage in having only one committer is you
>> always know the culprit.
>> I will change this tomorrow adding the JDK7 patch, but I will not commit
>> into a red master.
>>
>> Thanks,
>> Svante
>>
>>
>>
>>
>


Mime
View raw message