incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svante Schubert (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ODFTOOLKIT-305) Update ODF 1.2 schema to OpenDocument-v1.2 final version
Date Wed, 22 Feb 2012 12:43:49 GMT

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213577#comment-13213577
] 

Svante Schubert commented on ODFTOOLKIT-305:
--------------------------------------------

Calling "mvn clean compile -Pcodegen" skipping the JavaDoc, results in changes in 23 files,
22 manifest files and one below

odfdom\src\main\java\org\odftoolkit\odfdom\dom\attribute\text\TextOutlineLevelAttribute.java

In the above Java source the enumeration had been dropped without any reason - the random
factor of issue ODFTOOLKIT-199.

Have been using
java version "1.6.0_30"
Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

We could ask the other way around. What is the reason for the source changes this issue is
adding? 
There was NO schema change from ODF COS1 to ODF OS, therefore there should be NO Java source
changes at all!

Something different:
The time line of this issue is confusing me, you created this issue 21/Feb/12 10:12, I raised
objections 21/Feb/12 10:21 and "svn log" shows the patch
-----------
r1291683 | devinhan | 2012-02-21 11:06:53 +0100 (Di, 21 Feb 2012) | 1 line

#ODFTOOLKIT-305# Update ODF 1.2 schema to OpenDocument-v1.2 final version.[Developer:Devin]
-----------
Is the issue already in the master?
I have not noticed, that we switched from review than commit (RTC) to commit than review (CTR)?
In any case, shouldn't there be 72h to allow others to test and raise comments?

If the issue is already integrated, there is still an issue, as we are still downloading the
previous ODF candidate schema:
[INFO] --- wagon-maven-plugin:1.0-beta-3:download-single (download-odf-schema-v1.2) @ odfvalidator
---
[INFO] Downloading: http://docs.oasis-open.org/office/v1.2/cos01/OpenDocument-v1.2-cos01-schemas.zip
to E:\work\coding\odftoolkit-20120222\trunk\validator\target\schemas\OpenDocument-v1.2-cos01-schemas.zip

I would suggest to drop the Java source changes and just exchange the schema, as it has not
been changed aside of the header.
Even if our test run green, there have been set/get methods being removed, which might break
user's sources without any reason.

BTW it would be great if we could bring the ODF schema to a Maven repository, so the build
could work without Internet.

Thanks,
Svante
                
> Update ODF 1.2 schema to OpenDocument-v1.2 final version
> --------------------------------------------------------
>
>                 Key: ODFTOOLKIT-305
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-305
>             Project: ODF Toolkit
>          Issue Type: Improvement
>          Components: odfdom
>    Affects Versions: 0.8.8
>            Reporter: Devin Han
>            Assignee: Devin Han
>              Labels: ODF1.2
>
> The final ODF 1.2 schemas were published last month, see: http://lists.oasis-open.org/archives/tc-announce/201201/msg00001.html
> And we just updated the code generator to support mainfest and data dignature element/attribute
in issue ODFTOOLKIT-199.
> So I think it is time to update to the newest schemas for ODFDOM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message