incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devin Han (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ODFTOOLKIT-290) Consolidate build of ODFToolkit sub-projects
Date Mon, 17 Oct 2011 09:10:11 GMT

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128738#comment-13128738
] 

Devin Han commented on ODFTOOLKIT-290:
--------------------------------------

Thanks Yegor.
I reviewed your patch and did the following updates based on yours:
1. As we discussed in the dev mail list before, each component will continue maintain its
own version number. So I recovered version number setting for them. The details are:
    (1) xslt-runner-task 1.2.1-SNAPSHOT
    (2) xslt-runner 1.2.1-SNAPSHOT
    (3) odfvalidator 1.1.5-SNAPSHOT (not 0.8.8-SNAPSHOT,  as we mentioned before, the former
owner has given its number here:http://svn.apache.org/viewvc/incubator/odf/trunk/validator/src/main/java/org/odftoolkit/odfvalidator/Main.java?revision=1172466&view=markup#l41)
    (4) taglets 0.8.8-SNAPSHOT
    (5) odfdom-java  0.8.8-SNAPSHOT
    (6) simple-odf 0.7-SNAPSHOT
    (7) generator 0.8.8-SNAPSHOT
2. updated the maillist,scm, website and contributors' info for each pom.xml file.
3. updated <artifactId>from odf-parent to odf-toolkit
4. removed the restored OdfFileDom#getAutomaticStyles() which whe have fixed in bug #ODFTOOLKIT-291#
and adapted it to the newest code base.
5. We have done some licence header update work, so I adopted this patch with the former work
and now the rat licence test for all of the components have passed.

I ran the command "mvn clean install -Ppedantic"  several times and it built successfully.
I think this issue has been resolved and will mark it as fixed.

Devin

                
> Consolidate build of ODFToolkit sub-projects
> --------------------------------------------
>
>                 Key: ODFTOOLKIT-290
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-290
>             Project: ODF Toolkit
>          Issue Type: Improvement
>            Reporter: Yegor Kozlov
>            Assignee: Devin Han
>         Attachments: ip.patch
>
>
> As discussed on the dev list, we need to adjust the cross-module dependencies to compile
against trunk instead of hardcoded ODFDOM 0.8.7, Taglets 0.8.7, etc.
> I made an attempt to consolidate Maven build and propose the following structure under
a parent POM:
> {code}
> pom.xml (root) (modules: taglets,generator,xlst-runner,xslt-runner-task,odfdom,validator,simple)
>      +---- taglets
>                  +-- pom.xml  (parent: root)
>      +---- generator
>                  +---- schema2template 
>                          +-- pom.xml  (parent: generator)
>                  +---- schema2template-maven-plugin 
>                          +-- pom.xml  (parent: generator: dependeny: schema2template)
>      +---- xlst-runner
>                  +-- pom.xml   (parent: root)
>      +---- xlst-runner
>                  +-- pom.xml   (parent: root)
>      +---- xlst-runner-task
>                  +-- pom.xml   (parent: root)
>      +---- odfdom
>                  +-- pom.xml   (parent: root dependeny: taglets)
>      +---- validator
>                  +-- pom.xml   (parent: root dependeny: odfdom)
>      +---- simple
>                  +-- pom.xml   (parent: root dependeny: odfdom)
> {code}
> Summary of changes:
>  1. All sub-projects inherit the parent POM. This allows us to build and test all components
in one go. 
>  2. As per http://www.apache.org/dev/publishing-maven-artifacts.html, the parent POM
inherits the Apache POM. 
>  3. I changed the groupId to "org.apache.odftoolkit". The Maven artifacts should fit
in the Apache namespace.
>  4. Initial version is 0.5-SNAPSHOT 
>  5. [IMPORTANT] To test the build I had to restore  OdfFileDom#getAutomaticStyles().
Please revert this change after applying changes from https://issues.apache.org/jira/browse/ODFTOOLKIT-49
> Regards,
> Yegor

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message