incubator-odf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devin Han (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ODFTOOLKIT-287) PraragraphProperties should contain methods for margins and TextIndention
Date Mon, 10 Oct 2011 09:18:30 GMT

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123965#comment-13123965
] 

Devin Han commented on ODFTOOLKIT-287:
--------------------------------------

Thanks Oliver!
I reviewed your patch. It makes sense for users. 
Agree with most of your design, just change the method getInchValue(double value) from "protected"
to "private static".
This is an util method and will not be used out of ParagraphProperties, so the new access
scope maybe more suitable. Do you agree?

Devin
                
> PraragraphProperties should contain methods for margins and TextIndention
> -------------------------------------------------------------------------
>
>                 Key: ODFTOOLKIT-287
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-287
>             Project: ODF Toolkit
>          Issue Type: Improvement
>          Components: simple api
>            Reporter: Oliver Rau
>            Assignee: Devin Han
>         Attachments: ParagraphProperties.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message