incubator-npanday-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adelita Padilla <apadi...@g2ix.net>
Subject Re: svn commit: r1033832 - in /incubator/npanday/trunk: components/dotnet-artifact/src/main/java/npanday/artifact/impl/ plugins/maven-vsinstaller-plugin/ plugins/maven-vsinstaller-plugin/src/main/java/npanday/plugin/vsinstaller/ plugins/maven-vsinstaller-p...
Date Thu, 18 Nov 2010 12:31:46 GMT

Hi Brett,


----- "Brett Porter" <brett@apache.org> wrote:

> On 11/11/2010, at 7:05 PM, apadilla@apache.org wrote:
> 
> > 
> > +            String repo = System.getenv( "PROGRAMFILES" );
> 
> How portable is this? It might be better to have a configuration
> variable for the installation location, and set it to this if not
> specified?


Revised in r1036410


> 
> > +            writer.write( addin.replaceAll(
> "\\$\\{localRepository\\}", repo.replaceAll( "\\\\", "\\\\\\\\" ) )
> );
> 
> Should this be a different variable name to be clearer? Is there any


Revised in r1036410


> built-in technique that could be used to detect the location instead
> of the substitution?


I'm kinda confused on what built-in technique you meant here. Do you have any suggestion?

> 
> - Brett
> 
> --
> Brett Portery 
> brett@apache.org
> http://brettporter.wordpress.com/


Thanks,

Mime
View raw message