incubator-mod_ftp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Edmundsson <ni...@acc.umu.se>
Subject Re: Progress of migration to current APR API?
Date Fri, 08 Dec 2006 10:07:27 GMT
On Thu, 7 Dec 2006, William A. Rowe, Jr. wrote:

> Niklas Edmundsson wrote:
>>
>> Hi!
>>
>> Is there any progress with migrating mod_ftp to the current APR API?
>>
>> I'm really keen on starting to test this thing, but I don't want to do
>> patches that duplicate work that most likely already is in progress...
>
> I've just done a test build again against apr-1.2 and httpd-2.2 and see
> no flaws - if you have some could you post the compile errors?

Euh. And you're sure that you're not sitting on code that hasn't made 
it to mod_ftp trunk?

> So there don't seem to be APR api issues (there is no APR 2.0 today).
> There DO seem to be httpd-trunk issues related to httpd-2.3 (the dev
> branch) and therefore, someday, the httpd-2.4 general release.
>
> Again, if you observe something else, please post.

This is with httpd 2.2.3, compiled --with-included-apr 
--enable-maintainer-mode and mod_ftp revision 483902 on Ubuntu Dapper 
x86:
---------------------8<--------------------------
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o mod_ftp.lo mod_ftp.c && touch mod_ftp.slo
mod_ftp.c:182: warning: no previous prototype for 'merge_ftp_server_config'
mod_ftp.c:251: warning: no previous prototype for 'merge_ftp_dir_config'
mod_ftp.c: In function 'merge_ftp_dir_config':
mod_ftp.c:252: warning: unused variable 'base'
mod_ftp.c: In function 'ftp_set_limit_peruser':
mod_ftp.c:784: warning: format '%d' expects type 'int', but argument 4 has type 'const char
*'
mod_ftp.c: In function 'ftp_set_limit_perip':
mod_ftp.c:809: warning: format '%d' expects type 'int', but argument 4 has type 'const char
*'
mod_ftp.c: In function 'ftp_set_limit_perserver':
mod_ftp.c:834: warning: format '%d' expects type 'int', but argument 4 has type 'const char
*'
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_commands.lo ftp_commands.c && touch ftp_commands.slo
ftp_commands.c:185: warning: no previous prototype for 'ftp_parse2'
ftp_commands.c: In function 'ftp_cmd_list':
ftp_commands.c:725: warning: passing argument 1 of 'ap_strchr' discards qualifiers from pointer
target type
ftp_commands.c:725: warning: suggest parentheses around assignment used as truth value
ftp_commands.c:762: warning: passing argument 1 of 'ap_strchr' discards qualifiers from pointer
target type
ftp_commands.c:762: warning: suggest parentheses around assignment used as truth value
ftp_commands.c: In function 'ftp_cmd_mdtm':
ftp_commands.c:819: warning: implicit declaration of function 'apr_explode_localtime'
ftp_commands.c: In function 'ftp_cmd_nlst':
ftp_commands.c:960: warning: passing argument 1 of 'ap_strchr' discards qualifiers from pointer
target type
ftp_commands.c:960: warning: suggest parentheses around assignment used as truth value
ftp_commands.c: In function 'ftp_cmd_pasv':
ftp_commands.c:1385: warning: implicit declaration of function 'apr_socket_create_ex'
ftp_commands.c:1411: warning: implicit declaration of function 'apr_sockaddr_ip_set'
ftp_commands.c:1421: warning: implicit declaration of function 'apr_sockaddr_port_set'
ftp_commands.c:1423: warning: implicit declaration of function 'apr_bind'
ftp_commands.c:1467: warning: implicit declaration of function 'apr_listen'
ftp_commands.c:1491: warning: implicit declaration of function 'apr_sockaddr_port_get'
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_connection.lo ftp_connection.c && touch ftp_connection.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_data_connection.lo ftp_data_connection.c && touch ftp_data_connection.slo
ftp_data_connection.c: In function 'ftp_open_datasock':
ftp_data_connection.c:74: warning: implicit declaration of function 'apr_accept'
ftp_data_connection.c:120: warning: implicit declaration of function 'apr_connect'
ftp_data_connection.c: In function 'ftp_open_dataconn':
ftp_data_connection.c:44: warning: 'rv' may be used uninitialized in this function
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_data_filters.lo ftp_data_filters.c && touch ftp_data_filters.slo
ftp_data_filters.c: In function 'datasock_bucket_read':
ftp_data_filters.c:38: warning: unused variable 'c'
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_filters.lo ftp_filters.c && touch ftp_filters.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_glob.lo ftp_glob.c && touch ftp_glob.slo
ftp_glob.c: In function 'glob3':
ftp_glob.c:607: warning: function declaration isn't a prototype
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_inet_pton.lo ftp_inet_pton.c && touch ftp_inet_pton.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_limitlogin.lo ftp_limitlogin.c && touch ftp_limitlogin.slo
ftp_limitlogin.c: In function 'ftp_db_init':
ftp_limitlogin.c:89: warning: implicit declaration of function 'geteuid'
ftp_limitlogin.c:90: warning: implicit declaration of function 'chown'
ftp_limitlogin.c: In function 'ftp_mutexdb_cleanup':
ftp_limitlogin.c:128: warning: implicit declaration of function 'apr_pool_sub_make'
ftp_limitlogin.c:130: warning: implicit declaration of function 'unlink'
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_log.lo ftp_log.c && touch ftp_log.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_message.lo ftp_message.c && touch ftp_message.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_protocol.lo ftp_protocol.c && touch ftp_protocol.slo
ftp_protocol.c: In function 'ftp_read_line':
ftp_protocol.c:137: warning: implicit declaration of function 'getpid'
ftp_protocol.c: In function 'ftp_read_ahead_request':
ftp_protocol.c:382: warning: passing argument 1 of 'ap_strrchr' discards qualifiers from pointer
target type
ftp_protocol.c:382: warning: suggest parentheses around assignment used as truth value
ftp_protocol.c:384: warning: passing argument 1 of 'ap_strrchr' discards qualifiers from pointer
target type
ftp_protocol.c:384: warning: suggest parentheses around assignment used as truth value
ftp_protocol.c:386: warning: passing argument 1 of 'ap_strrchr' discards qualifiers from pointer
target type
ftp_protocol.c:386: warning: suggest parentheses around assignment used as truth value
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_request.lo ftp_request.c && touch ftp_request.slo
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=compile gcc -prefer-pic
-O2 -march=i686 -g  -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -DAP_DEBUG
-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I/lap/apache/2.2.3.nikkemekar/include/apache2   -I/lap/apache/2.2.3.nikkemekar/include/apache2
 -I../../include  -c -o ftp_util.lo ftp_util.c && touch ftp_util.slo
ftp_util.c: In function 'ftp_direntry_make':
ftp_util.c:107: warning: passing argument 1 of 'ap_strchr' discards qualifiers from pointer
target type
ftp_util.c:107: warning: suggest parentheses around assignment used as truth value
ftp_util.c:158: warning: implicit declaration of function 'apr_get_username'
ftp_util.c:163: warning: implicit declaration of function 'apr_get_groupname'
ftp_util.c:170: warning: implicit declaration of function 'apr_explode_localtime'
/lap/apache/2.2.3.nikkemekar/share/apache2/build/libtool --silent --mode=link gcc -o mod_ftp.la
 -rpath /lap/apache/2.2.3.nikkemekar/libexec -module -avoid-version    ftp_util.lo ftp_request.lo
ftp_protocol.lo ftp_message.lo ftp_log.lo ftp_limitlogin.lo ftp_inet_pton.lo ftp_glob.lo ftp_filters.lo
ftp_data_filters.lo ftp_data_connection.lo ftp_connection.lo ftp_commands.lo mod_ftp.lo
---------------------8<--------------------------

Every "implicit declaration" seems to be an obsoleted APR function 
according to srclib/apr/CHANGES, and the symbol doesn't exist so the 
module doesn't load. I would have preferred that gcc errored out when 
missing prototypes so these things would be easier to catch, since now 
it builds but doesn't load...

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Never lie unless you have an awfully good memory.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Mime
View raw message