incubator-mod_ftp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kanagasabai Sriskanthaverl <s...@covalent.net>
Subject Re: mod_ftp patch: New directive FTPDirUmask
Date Thu, 13 Apr 2006 17:33:47 GMT
Hi guys,
Here is the 2nd version of the patch with added portability by way of
using apr_file_perms_set instead of chmod. Could any comitter can review
and commit this pls?

Regards
Sris



On Tue, 2006-03-28 at 14:05 -0600, William A. Rowe, Jr. wrote:
> Kanagasabai Sriskanthaverl wrote:
> > Hi Paul, thx for ur comments.
> > 
> > There is one warning like 
> > "Some platforms may not be able to apply all of the available permission
> > bits; APR_INCOMPLETE will be returned if some permissions are specified
> > which could not be set." 
> 
> That's true of the same platforms which won't set all the permissions using
> chmod/fchmod; it's not an apr restriction.  The APR_INCOMPLETE result means
> that it could set some (say, the user and/or everyone permissions), but can't
> map them all (this platform doesn't have a unix owner/group/world model.)
> 
> > the platforms that falls in this category may end up in unpredictable
> > behavior.
> 
> Of course.  Same platforms where your existing #ifdef would be skipped.
> 
> > Further I did not understand, how can I select the appropriate file
> > permissions flag on the fly with respect to the mask?. I see calculating
> > permission codes easier for chmod.
> 
> True.  These are simply hex rather than octal.  Perhaps, read in the user's
> setting mask in hex?  We could move to this API in the stor/appe code as well.
> 
> Bill

Mime
View raw message