incubator-mod_ftp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: mod_ftp patch: New directive FTPDirUmask
Date Tue, 28 Mar 2006 14:13:48 GMT

On Mar 28, 2006, at 1:21 AM, Paul Querna wrote:

> Kanagasabai Sriskanthaverl wrote:
>> Hi guys,
>> I have written a patch for mod_ftp, which defines a new directive
>> FTPDirUmask, allows to configure the umask for MKDIR command.
>
>
> I like the idea.  I think we should add this.
>

+1

>> Index: src/mod_ftp.c
>> ===================================================================
>> --- src/mod_ftp.c	(revision 388162)
>> +++ src/mod_ftp.c	(working copy)
> .....
>> @@ -813,6 +866,8 @@
>>  		 "Run an FTP server on this host"),
>>      AP_INIT_TAKE1("FTPUmask", ftp_umask, NULL, RSRC_CONF,
>>  		  "Set the umask for created files"),
>> +    AP_INIT_TAKE1("FTPDirUmask", ftp_dirumask, NULL, RSRC_CONF,
>> +		  "Set the umask for created directory"),
>>      AP_INIT_TAKE1("FTPTimeoutLogin", ftp_set_int_slot,
>>                    (void *)APR_XtOffsetOf 
>> (ftp_server_config,                                            
>> timeout_login), RSRC_CONF,
>
> It seems like we might want to inherit the value for FTPDirUmask  
> from the value of FTPUmask, if FTPDirUmask is not set? Thoughts?
>

Yeah... makes sense.

Mime
View raw message