Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============7276905581562730051=="
MIME-Version: 1.0
Subject: Re: Review Request 12215: Refactored os::Process to use Try's for
 memory and
 CPU information.
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Benjamin Hindman" <benh@berkeley.edu>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Tue, 02 Jul 2013 14:26:34 -0000
Message-ID: <20130702142634.26284.31396@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
References: <20130702024655.26284.88886@reviews.apache.org>
In-Reply-To: <20130702024655.26284.88886@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>

--===============7276905581562730051==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12215/#review22660
-----------------------------------------------------------

Ship it!


I like wrapping those values in a Try, alternatively you could just use an Option (which makes it look less like a half broken Process and more like a Process with no resource statistics). The important part is that users will need to do something like 'process.rss.isSome()'.

- Benjamin Hindman


On July 2, 2013, 2:46 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12215/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 2:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was reported by Brenden Matthews on the mailing list. It appears that on some Linux systems the utime / stime values coming from /proc are corrupt.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp ef6c6c8f7839baaddcfd20249f2dbd25a7c3d25a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 3f4e9d4c64bf5a9027aa26aab24c6f02d76b8bfc 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp 806949bb29ad15e97851697dcdeeb17396ebe459 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp c5ad25bd03c573119494fb41e2cf075ecb67b3d8 
> 
> Diff: https://reviews.apache.org/r/12215/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also ran the isolator tests with 100 iterations.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


--===============7276905581562730051==--