Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F197EC33E for ; Fri, 28 Jun 2013 06:31:02 +0000 (UTC) Received: (qmail 16456 invoked by uid 500); 28 Jun 2013 06:31:02 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 16251 invoked by uid 500); 28 Jun 2013 06:31:02 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 16239 invoked by uid 99); 28 Jun 2013 06:31:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jun 2013 06:31:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1E22A1CD242; Fri, 28 Jun 2013 06:30:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4396185526307628912==" MIME-Version: 1.0 Subject: Re: Review Request 12145: Fixed a misplaced assertion that in rare occasions caused test failures. From: "Jiang Yan Xu" To: "Benjamin Hindman" , "Ben Mahler" , "Vinod Kone" Cc: "Jiang Yan Xu" , "mesos" Date: Fri, 28 Jun 2013 06:30:53 -0000 Message-ID: <20130628063053.23542.76674@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/12145/ X-Sender: "Jiang Yan Xu" References: <20130628005636.23542.74860@reviews.apache.org> In-Reply-To: <20130628005636.23542.74860@reviews.apache.org> Reply-To: "Jiang Yan Xu" --===============4396185526307628912== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12145/ ----------------------------------------------------------- (Updated June 28, 2013, 6:30 a.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Changes ------- BenM's comments. Summary (updated) ----------------- Fixed a misplaced assertion that in rare occasions caused test failures. Bugs: MESOS-534 https://issues.apache.org/jira/browse/MESOS-534 Repository: mesos Description ------- - Reaper could have reaped the pid at the time of the assertion. - Issue: https://issues.apache.org/jira/browse/MESOS-534 Diffs (updated) ----- src/tests/reaper_tests.cpp c9818ac Diff: https://reviews.apache.org/r/12145/diff/ Testing ------- - ./bin/mesos-tests.sh --gtest_filter="ReaperTest.TerminatedChildProcess" --gtest_repeat=1000 --gtest_break_on_failure Passed. - However, ./bin/mesos-tests.sh --gtest_filter="ReaperTest.NonChildProcess" --gtest_repeat=1000 --gtest_break_on_failure is still flaky: [ RUN ] ReaperTest.NonChildProcess Detaching after fork from child process 25627. libprocess: reaper(788)@10.35.255.108:45752 terminating due to basic_filebuf::underflow error reading the file - Seems to be related to this though: https://issues.apache.org/jira/browse/MESOS-434 Thanks, Jiang Yan Xu --===============4396185526307628912==--