Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 103B6106BD for ; Fri, 14 Jun 2013 00:30:05 +0000 (UTC) Received: (qmail 29087 invoked by uid 500); 14 Jun 2013 00:30:04 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 29059 invoked by uid 500); 14 Jun 2013 00:30:04 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 29040 invoked by uid 99); 14 Jun 2013 00:30:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2013 00:30:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4FDB31CCBC5; Fri, 14 Jun 2013 00:29:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4755776127354355568==" MIME-Version: 1.0 Subject: Re: Review Request: WebUI: Use slave hostname rather than libprocess. From: "Ben Mahler" To: "Ben Mahler" , "mesos" , "Brenden Matthews" Date: Fri, 14 Jun 2013 00:29:56 -0000 Message-ID: <20130614002956.1041.53206@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11813/ X-Sender: "Ben Mahler" References: <20130614002006.3558.30280@reviews.apache.org> In-Reply-To: <20130614002006.3558.30280@reviews.apache.org> Reply-To: "Ben Mahler" --===============4755776127354355568== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 14, 2013, 12:20 a.m., Ben Mahler wrote: > > Thanks Brenden! For posterity we always update the diff on reviewboard = prior to submitting the change. Can you update the diff on this one with yo= ur fixes? > = > Brenden Matthews wrote: > My bad. Diff attached. Much appreciated!! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11813/#review21886 ----------------------------------------------------------- On June 14, 2013, 12:24 a.m., Brenden Matthews wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11813/ > ----------------------------------------------------------- > = > (Updated June 14, 2013, 12:24 a.m.) > = > = > Review request for mesos. > = > = > Description > ------- > = > WebUI: Use slave hostname rather than libprocess. > = > It's safer to use the hostname of the slave rather than the libprocess > IP since we don't necessarily know that the interface's IP is publicly > accessible. This applies especially for services like EC2. > = > Review: https://reviews.apache.org/r/11813 > = > = > Diffs > ----- > = > src/webui/master/static/controllers.js 0ea77ce = > = > Diff: https://reviews.apache.org/r/11813/diff/ > = > = > Testing > ------- > = > Tested by test-driving the web UI. > = > = > Thanks, > = > Brenden Matthews > = > --===============4755776127354355568==--