Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2501132459056813541=="
MIME-Version: 1.0
Subject: Re: Review Request: Fix executor IDs in web UI.
From: "Brenden Matthews" <brenden@diddyinc.com>
To: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>,
 "Brenden Matthews" <brenden@diddyinc.com>
Date: Thu, 13 Jun 2013 16:42:02 -0000
Message-ID: <20130613164202.3558.90107@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brenden Matthews" <noreply@reviews.apache.org>
References: <20130613013809.1041.13333@reviews.apache.org>
In-Reply-To: <20130613013809.1041.13333@reviews.apache.org>
Reply-To: "Brenden Matthews" <brenden@diddyinc.com>

--===============2501132459056813541==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On June 13, 2013, 1:38 a.m., Ben Mahler wrote:
> > After doing some digging, I'm guessing you made this change because of =
the links present on the /frameworks/FID page of the webui? Can you update =
the review description to comment on what the issue was that prompted this =
change? It would be much appreciated and helps us understand the context be=
hind the change.
> >

I added a more detailed description to the commit message.  Here's an examp=
le of master/state.json which demonstrates this (note that executor_id is e=
mpty):

{
activated_slaves: 49,
build_date: "2013-05-25 17:08:21",
build_time: 1369501701,
build_user: "root",
cluster: "aircluster h1",
completed_frameworks: [ ],
deactivated_slaves: 0,
failed_tasks: 6,
finished_tasks: 351,
frameworks: [
{},
{
active: 1,
completed_tasks: [],
id: "chronos",
name: "chronos1370908249773",
offers: [ ],
registered_time: 1371082659,
reregistered_time: 1371084129,
resources: {},
tasks: [
{
executor_id: "",
framework_id: "chronos",
id: "ct:hosting_logs_yesterday:1371140902215:0",
name: "ChronosTask:hosting_logs_yesterday",
resources: {
cpus: 1,
disk: 1024,
mem: 1024
},
slave_id: "201306122129-1707151626-5050-5724-19",
state: "TASK_RUNNING"
}
],
unregistered_time: 0,
user: "root"
},
...


> On June 13, 2013, 1:38 a.m., Ben Mahler wrote:
> > src/webui/master/static/controllers.js, lines 214-219
> > <https://reviews.apache.org/r/11814/diff/2/?file=3D303951#file303951lin=
e214>
> >
> >     Rather than setting the executor ID here (which is somewhat mislead=
ing since the task does not have an executor specified), it would be better=
 to adjust framework.html to correctly set the link.
> >     =

> >     You can do this with the ui-if directive (see browse.html) for an e=
xample.
> >     =

> >     This is relevant regardless of whether I correctly guessed the issu=
e. :)

I'm not sure I understand how to do this in the HTML.  As far as I can tell=
, the HTML is just a template with fields that are substituted by the javas=
cript.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11814/#review21833
-----------------------------------------------------------


On June 12, 2013, 2:21 a.m., Brenden Matthews wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11814/
> -----------------------------------------------------------
> =

> (Updated June 12, 2013, 2:21 a.m.)
> =

> =

> Review request for mesos.
> =

> =

> Description
> -------
> =

> Fix executor IDs in web UI.
> =

> Review: https://reviews.apache.org/r/11814
> =

> =

> Diffs
> -----
> =

>   src/webui/master/static/controllers.js 0ea77cec2d6ca520e69fd74eb56fe05d=
32b711bd =

>   src/webui/master/static/framework.html c2d770bc40fae90ed6e3bb6b4b37cad5=
51d69956 =

> =

> Diff: https://reviews.apache.org/r/11814/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Brenden Matthews
> =

>


--===============2501132459056813541==--