Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2790710720 for ; Tue, 11 Jun 2013 21:30:40 +0000 (UTC) Received: (qmail 25457 invoked by uid 500); 11 Jun 2013 21:30:40 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 25413 invoked by uid 500); 11 Jun 2013 21:30:40 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 25403 invoked by uid 99); 11 Jun 2013 21:30:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 21:30:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CD0C51CC91A; Tue, 11 Jun 2013 21:30:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3608644567693674110==" MIME-Version: 1.0 Subject: Re: Review Request: Don't accept offers on the same host/port. From: "Brenden Matthews" To: "Vinod Kone" , "mesos" , "Brenden Matthews" Date: Tue, 11 Jun 2013 21:30:32 -0000 Message-ID: <20130611213032.3558.66508@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brenden Matthews" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11161/ X-Sender: "Brenden Matthews" References: <20130611211258.3558.7680@reviews.apache.org> In-Reply-To: <20130611211258.3558.7680@reviews.apache.org> Reply-To: "Brenden Matthews" --===============3608644567693674110== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 11, 2013, 9:12 p.m., Vinod Kone wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lin= es 427-428 > > > > > > Isn't 'begin' always equal to 'range.getBegin()' and 'end' always e= qual to 'range.getEnd()' ? I didn't want to make the assumption that the range was ordered by smallest= first. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11161/#review21741 ----------------------------------------------------------- On June 11, 2013, 8:56 p.m., Brenden Matthews wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11161/ > ----------------------------------------------------------- > = > (Updated June 11, 2013, 8:56 p.m.) > = > = > Review request for mesos. > = > = > Description > ------- > = > Don't accept offers on the same host/port. > = > We'll try to find a port combination that hasn't already been used to > launch a TaskTracker. > = > Review: https://reviews.apache.org/r/11161/ > = > = > Diffs > ----- > = > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe4= 01f5265e3d9494af7eace42eec45943184a3 = > = > Diff: https://reviews.apache.org/r/11161/diff/ > = > = > Testing > ------- > = > Used in production at airbnb. > = > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make ha= doop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > = > = > Thanks, > = > Brenden Matthews > = > --===============3608644567693674110==--