Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A4A5F10F26 for ; Tue, 4 Jun 2013 00:54:03 +0000 (UTC) Received: (qmail 4205 invoked by uid 500); 4 Jun 2013 00:54:03 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 4162 invoked by uid 500); 4 Jun 2013 00:54:03 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 4149 invoked by uid 99); 4 Jun 2013 00:54:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 00:54:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 395A81CC6CB; Tue, 4 Jun 2013 00:53:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8381882818646247162==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed Zookeeper master detector to only create zookeeper paths when it is contending. From: "Ben Mahler" To: "Benjamin Hindman" , "Ben Mahler" , "Bill Farner" , "Raul Gutierrez Segales" Cc: "Vinod Kone" , "mesos" Date: Tue, 04 Jun 2013 00:53:57 -0000 Message-ID: <20130604005357.22853.11588@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11366/ X-Sender: "Ben Mahler" References: <20130604000310.22886.25258@reviews.apache.org> In-Reply-To: <20130604000310.22886.25258@reviews.apache.org> Reply-To: "Ben Mahler" --===============8381882818646247162== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review21389 ----------------------------------------------------------- Ship it! configure.ac Intended? src/zookeeper/zookeeper.cpp Well, deletion seems dangerous in the face of many detectors operating = at once on the same path, no? - Ben Mahler On June 4, 2013, 12:03 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > = > (Updated June 4, 2013, 12:03 a.m.) > = > = > Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and = Raul Gutierrez Segales. > = > = > Description > ------- > = > This is likely a short term fix pending Yan's refactor of detector. > = > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > = > = > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > = > = > Diffs > ----- > = > configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e = > src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b = > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 = > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 = > = > Diff: https://reviews.apache.org/r/11366/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============8381882818646247162==--