Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14E541043D for ; Mon, 3 Jun 2013 20:44:28 +0000 (UTC) Received: (qmail 21374 invoked by uid 500); 3 Jun 2013 20:44:28 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 21347 invoked by uid 500); 3 Jun 2013 20:44:27 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 21334 invoked by uid 99); 3 Jun 2013 20:44:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2013 20:44:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8BA4A1CC63D; Mon, 3 Jun 2013 20:44:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1426194353138715855==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed Zookeeper master detector to only create zookeeper paths when it is contending. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Ben Mahler" , "Bill Farner" , "Raul Gutierrez Segales" Cc: "Vinod Kone" , "mesos" Date: Mon, 03 Jun 2013 20:44:21 -0000 Message-ID: <20130603204421.22886.7455@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11366/ X-Sender: "Benjamin Hindman" References: <20130530183957.1348.67331@reviews.apache.org> In-Reply-To: <20130530183957.1348.67331@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============1426194353138715855== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11366/#review21354 ----------------------------------------------------------- src/detector/detector.cpp Why the extra check if create is going to do it for us? src/zookeeper/zookeeper.cpp I propose that the core ZooKeeper::create function works as follows: = If we're trying to create '/a/b/c/d' we should start by checking if '/a= /b/c/d' exists. If it does (and we aren't being asked to create an ephemera= l child), we should just return. If it doesn't exist and we've been asked t= o do the create "recursively", we should check if '/a/b/c' exists, and if n= ot then '/a/b', and if not '/a', etc. You might even be able to just do thi= s recursively with create as it is today (modifying arguments as necessary). - Benjamin Hindman On May 30, 2013, 6:39 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11366/ > ----------------------------------------------------------- > = > (Updated May 30, 2013, 6:39 p.m.) > = > = > Review request for mesos, Benjamin Hindman, Bill Farner, Ben Mahler, and = Raul Gutierrez Segales. > = > = > Description > ------- > = > This is likely a short term fix pending Yan's refactor of detector. > = > 2 changes: > 1) Fixed a bug in zookeeper->create(). > 2) Removed create for non-contending detectors. > = > = > This addresses bug mesos-409. > https://issues.apache.org/jira/browse/mesos-409 > = > = > Diffs > ----- > = > configure.ac 8b6d74fd78613965340ecff71bb933c9c4d24e9e = > src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e = > src/tests/zookeeper_tests.cpp 77a5ab259e907f8df7ae88271da467b673895a5b = > src/zookeeper/zookeeper.hpp 99e689e5178845480b2426e694d18c5257234166 = > src/zookeeper/zookeeper.cpp 267c38a2922f114519ffaf4f0bdce74d22fc1506 = > = > Diff: https://reviews.apache.org/r/11366/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============1426194353138715855==--