Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E37ACD3E for ; Mon, 3 Jun 2013 17:56:28 +0000 (UTC) Received: (qmail 88833 invoked by uid 500); 3 Jun 2013 17:56:27 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 88697 invoked by uid 500); 3 Jun 2013 17:56:27 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 88673 invoked by uid 99); 3 Jun 2013 17:56:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2013 17:56:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08DF91CC60B; Mon, 3 Jun 2013 17:56:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2477354552691522836==" MIME-Version: 1.0 Subject: Re: Review Request: Terminate executors that aren't needed. From: "Brenden Matthews" To: "Vinod Kone" , "mesos" , "Brenden Matthews" Date: Mon, 03 Jun 2013 17:56:18 -0000 Message-ID: <20130603175618.22886.37484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brenden Matthews" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/11125/ X-Sender: "Brenden Matthews" References: <20130514002048.23050.57745@reviews.apache.org> In-Reply-To: <20130514002048.23050.57745@reviews.apache.org> Reply-To: "Brenden Matthews" --===============2477354552691522836== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11125/ ----------------------------------------------------------- (Updated June 3, 2013, 5:56 p.m.) Review request for mesos. Description (updated) ------- Terminate executors that aren't needed. If we launch an executor and then kill the task immediately after, make sure we also terminate the executor when there are no other tasks. Review: https://reviews.apache.org/r/11125 Diffs (updated) ----- src/slave/slave.cpp e905ab3cd965002592c1f70c85ea3378ac8982b0 = Diff: https://reviews.apache.org/r/11125/diff/ Testing ------- Used in production at airbnb. Thanks, Brenden Matthews --===============2477354552691522836==--