incubator-mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brenden Matthews" <>
Subject Re: Review Request 11975: Use hostname instead of IP for redirection.
Date Wed, 26 Jun 2013 21:54:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 26, 2013, 9:54 p.m.)

Review request for mesos.


Updated as per Vinod's comments.

Repository: mesos

Description (updated)

Use hostname instead of IP for redirection.

In the Web UI, the redirection does not work for hosts where the local
interface address is not publicly accessible.  For example, with EC2 the
redirection will not work.

This change writes the Master's hostname into ZooKeeper, thereby
allowing the redirection to work with private IP addresses.


Diffs (updated)

  src/detector/detector.hpp b0e66888050c1987b7200cdbf21ebe5e2e55e6c0 
  src/detector/detector.cpp 12deefa0b9df3f4946d80f500caaa5199b8ea28e 
  src/local/local.cpp 3364c15f6b2374d752e83eb8a1c3c49de6bcc259 
  src/master/http.cpp 47471d6881fa1b101cdeb3fb48a59712490267e9 
  src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b 
  src/master/master.hpp 86c5232d57e9e86e13acf48b68f1e3cf23442495 
  src/master/master.cpp a0b862a4f825c00dec2b73f993fe58d8aa90812b 
  src/messages/messages.proto 2c196eee0f3adba90799878b7e126bc85f635b65 
  src/sched/sched.cpp 7ea82e547c612159c9fa24fb6d62e3d2b5f11982 
  src/slave/main.cpp 750a12766bde64059bfd4635ea077cbd43cb4301 
  src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9 
  src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526 
  src/webui/master/static/controllers.js f9d7c978fe4cf6d2fbb4d45990b277e44485f0cd 



make check


Brenden Matthews

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message