Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============0533049363246972060=="
MIME-Version: 1.0
Subject: Re: Review Request: Upgraded libev to 4.15.
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Vinod Kone" <vinodkone@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Tue, 21 May 2013 15:38:08 -0000
Message-ID: <20130521153808.13725.6598@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
References: <20130521064449.13726.59889@reviews.apache.org>
In-Reply-To: <20130521064449.13726.59889@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>

--===============0533049363246972060==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11289/#review20849
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 21, 2013, 6:44 a.m., Vinod Kone wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11289/
> -----------------------------------------------------------
> =

> (Updated May 21, 2013, 6:44 a.m.)
> =

> =

> Review request for mesos, Benjamin Hindman and Ben Mahler.
> =

> =

> Description
> -------
> =

> See summary.
> =

> Works as expected on CentOS. But having issues getting make check to work=
 on OSX. See below.
> =

> =

> Diffs
> -----
> =

>   third_party/libprocess/src/encoder.hpp ec5e2717fddd0ffc1ea1bccce25652b6=
7e723f7f =

>   third_party/libprocess/third_party/Makefile.am b846173f44b1e2d5415231ef=
52eefcbc027f1aee =

>   third_party/libprocess/third_party/libev-3.8.patch 8f7ac91349134d638668=
d1beb9a6928167562fe2 =

>   third_party/libprocess/third_party/libev-3.8.tar.gz 6db7e888530916e1389=
58da23cc89b2dfa858a8a =

>   third_party/libprocess/third_party/libev-4.15.patch PRE-CREATION =

>   third_party/libprocess/third_party/libev-4.15.tar.gz PRE-CREATION =

>   third_party/libprocess/third_party/versions.am b3a766a8e8e90ded88cb8720=
f372555dcc111322 =

> =

> Diff: https://reviews.apache.org/r/11289/diff/
> =

> =

> Testing
> -------
> =

> All tests pass on CentOS-5.6.
> =

> make passes on OSX 10.8.
> =

> But make check on OSX 10.8 fails as follows:
> =

> g++ -DPACKAGE_NAME=3D\"libprocess\" -DPACKAGE_TARNAME=3D\"libprocess\" -D=
PACKAGE_VERSION=3D\"0.0.1\" -DPACKAGE_STRING=3D\"libprocess\ 0.0.1\" -DPACK=
AGE_BUGREPORT=3D\"\" -DPACKAGE=3D\"libprocess\" -DVERSION=3D\"0.0.1\" -DSTD=
C_HEADERS=3D1 -DHAVE_SYS_TYPES_H=3D1 -DHAVE_SYS_STAT_H=3D1 -DHAVE_STDLIB_H=
=3D1 -DHAVE_STRING_H=3D1 -DHAVE_MEMORY_H=3D1 -DHAVE_STRINGS_H=3D1 -DHAVE_IN=
TTYPES_H=3D1 -DHAVE_STDINT_H=3D1 -DHAVE_UNISTD_H=3D1 -DHAVE_DLFCN_H=3D1 -DL=
T_OBJDIR=3D\".libs/\" -DHAVE_PTHREAD=3D1 -DHAVE_LIBZ=3D1 -I. -I../../../thi=
rd_party/libprocess  -I../../../third_party/libprocess/src -Ithird_party/gm=
ock-1.6.0/gtest/include -Ithird_party/gmock-1.6.0/include -I../../../third_=
party/libprocess/include -I../../../third_party/libprocess/third_party/stou=
t/include -Ithird_party/boost-1.53.0 -Ithird_party/glog-0.3.1/src -Ithird_p=
arty/libev-4.15 -Ithird_party/ry-http-parser-1c3624a     -g -MT tests-http_=
tests.o -MD -MP -MF .deps/tests-http_tests.Tpo -c -o tests-http_tests.o `te=
st -f 'src/tests/http_tests.cpp' || echo '../../../third_party/libprocess/'=
`src/tests/http_tests.cpp
> In file included from ../../../third_party/libprocess/src/encoder.hpp:4,
>                  from ../../../third_party/libprocess/src/tests/encoder_t=
ests.cpp:12:
> third_party/libev-4.15/ev.h:234: error: expected identifier before numeri=
c constant
> third_party/libev-4.15/ev.h:234: error: expected `}' before numeric const=
ant
> third_party/libev-4.15/ev.h:234: error: expected unqualified-id before nu=
meric constant
> third_party/libev-4.15/ev.h:842: error: expected declaration before =E2=
=80=98}=E2=80=99 token
> make[5]: *** [tests-encoder_tests.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
> In file included from ../../../third_party/libprocess/src/encoder.hpp:4,
>                  from ../../../third_party/libprocess/src/tests/http_test=
s.cpp:20:
> third_party/libev-4.15/ev.h:234: error: expected identifier before numeri=
c constant
> third_party/libev-4.15/ev.h:234: error: expected `}' before numeric const=
ant
> third_party/libev-4.15/ev.h:234: error: expected unqualified-id before nu=
meric constant
> third_party/libev-4.15/ev.h:842: error: expected declaration before =E2=
=80=98}=E2=80=99 token
> make[5]: *** [tests-http_tests.o] Error 1
> mv -f .deps/tests-decoder_tests.Tpo .deps/tests-decoder_tests.Po
> make[4]: *** [check-am] Error 2
> make[3]: *** [check-recursive] Error 1
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check] Error 2
> make: *** [check-recursive] Error 1
> =

> =

> Thanks,
> =

> Vinod Kone
> =

>


--===============0533049363246972060==--