Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DB2AF8FA for ; Wed, 1 May 2013 22:41:28 +0000 (UTC) Received: (qmail 61713 invoked by uid 500); 1 May 2013 22:41:28 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 61615 invoked by uid 500); 1 May 2013 22:41:28 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 61603 invoked by uid 99); 1 May 2013 22:41:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 May 2013 22:41:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 289CC1C94B6; Wed, 1 May 2013 22:41:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2782846202423628228==" MIME-Version: 1.0 Subject: Re: Review Request: Implemented Rate limiter abstraction. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Ben Mahler" Cc: "Vinod Kone" , "mesos" Date: Wed, 01 May 2013 22:41:24 -0000 Message-ID: <20130501224124.17259.2468@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10891/ X-Sender: "Benjamin Hindman" References: <20130501215733.17259.57328@reviews.apache.org> In-Reply-To: <20130501215733.17259.57328@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============2782846202423628228== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10891/#review20032 ----------------------------------------------------------- Ship it! third_party/libprocess/include/process/limiter.hpp This was my bad, shouldn't require CHECK. s/CHECK/assert/ and add inclu= de above. - Benjamin Hindman On May 1, 2013, 9:57 p.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10891/ > ----------------------------------------------------------- > = > (Updated May 1, 2013, 9:57 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > BenH's patch. > = > = > Diffs > ----- > = > third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fd= c0f8 = > third_party/libprocess/include/process/limiter.hpp PRE-CREATION = > third_party/libprocess/src/tests/process_tests.cpp 8fbf19676c54eb0da6f8= daa042de127608bcb00b = > = > Diff: https://reviews.apache.org/r/10891/diff/ > = > = > Testing > ------- > = > sudo ./third_party/libprocess/tests --gtest_filter=3D"*limiter*" --verbos= e --gtest_repeat=3D1000 --gtest_break_on_failure > = > = > Thanks, > = > Vinod Kone > = > --===============2782846202423628228==--