Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0335DF64F for ; Fri, 5 Apr 2013 17:57:32 +0000 (UTC) Received: (qmail 9904 invoked by uid 500); 5 Apr 2013 17:57:31 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 9881 invoked by uid 500); 5 Apr 2013 17:57:31 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 9872 invoked by uid 99); 5 Apr 2013 17:57:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 17:57:31 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of vinod@twitter.com designates 209.85.219.51 as permitted sender) Received: from [209.85.219.51] (HELO mail-oa0-f51.google.com) (209.85.219.51) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 17:57:26 +0000 Received: by mail-oa0-f51.google.com with SMTP id g12so4302622oah.10 for ; Fri, 05 Apr 2013 10:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=twitter.com; s=google; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=0dEY3xpVadMiySwwDKG9BPANctfnPdSPdjhSUtpbxBQ=; b=l6u6KCS4ZiWKzq75JWv/XSKA2hKOa0RlqEmvS1bIEAGLt8Q4MwOjblHZTkYP2LDkdK AJKBZpufYfDY8PAIB69nNjXIidinYdcu4qYp94FVhDNHrvj4nK/0+Qxz08t00ONtyAIq tNts6Bu634BeND/ChHlKnZI/igoOyYiM11ap8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=0dEY3xpVadMiySwwDKG9BPANctfnPdSPdjhSUtpbxBQ=; b=RC4srYWinlj8EosVnVQNzpgItiZn+o8U7hLx8LlvF1dITHyr2Sw7kZezM5jAfGu4Ee xzkF6kAFUNCctqAWO9wBoXn7gcv8VKc6s141g+is4DimQeoYXHa2so8RpwbXYB2uhiqA 6v7tJR2xVsgDM9hszwsnf0dnhlGaVmTxkcTd3LGrYpEhjPcZ+ZskA5VCcFHO+ERNqraO 9yrQoO5xlayqMdosgjviNnKwdDaPI9K59q7bZNgjbLvDjEPqsgvYfZN6G2qvK7FH0W4Z Dp28b0n1SQdXYDRRJf1a/4TduzYGC9z3EifZAmyRLNphigf+p262n81z3oKSR4gguvmd Z6Cw== X-Received: by 10.182.129.101 with SMTP id nv5mr8580092obb.56.1365184625025; Fri, 05 Apr 2013 10:57:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.80.70 with HTTP; Fri, 5 Apr 2013 10:56:43 -0700 (PDT) In-Reply-To: <20130405174341.23824.38198@reviews.apache.org> References: <20130405174341.23824.38198@reviews.apache.org> From: Vinod Kone Date: Fri, 5 Apr 2013 10:56:43 -0700 Message-ID: Subject: Re: Review Request: Added DROP_PROTOBUF. To: Benjamin Hindman Cc: mesos Content-Type: multipart/alternative; boundary=e89a8fb1ebe4a0ff9804d9a0d04b X-Gm-Message-State: ALoCoQmdOQFgvIzupTBzPsG+TSM06mb0AYytkSOwEwBq5jGykv8eq7AvAsnHqGblTHdLx+7yj/GI X-Virus-Checked: Checked by ClamAV on apache.org --e89a8fb1ebe4a0ff9804d9a0d04b Content-Type: text/plain; charset=ISO-8859-1 looks like you extended FutureProtobuf to take a bool 'drop'. I ended up just creating DropProtobuf() and DropProtobufs(). @vinodkone On Fri, Apr 5, 2013 at 10:43 AM, Benjamin Hindman wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10307/ > Review request for mesos and Vinod Kone. > By Benjamin Hindman. > Description > > See summary. > > Testing > > N/A > > Diffs > > - src/tests/utils.hpp (9fee0ca68d4a0c307e875a7e520fd00c5f9a7b57) > > View Diff > --e89a8fb1ebe4a0ff9804d9a0d04b--