Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of benjamin.mahler@gmail.com
 designates 209.85.220.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAPXBsRDhQaHXB=JgxC4OMTX8-zQdtEsF2rUsWRK6VRRn6j9i9w@mail.gmail.com>
References: 
 <CAPXBsRBi6KhBdqgxtvT48+u8SY4JEu=5v4LwAAZp5Ed=3_pFKg@mail.gmail.com>
 <CA+8RcoSZUvZz8Oqzcm8z_ZwG_E46kke=apyJ9VGW3-mSU=OBmg@mail.gmail.com>
 <CAAkWvAy_=5OgwPjoUnZM-DucxSBijKmVK-LHqZCM2VoJRBv2sg@mail.gmail.com>
 <CAPXBsRCFuCemUmTYdDMwgREBVsZ+ZkABa78soWyHVWjJAPrPoQ@mail.gmail.com>
 <CA+8RcoSPrRRf2mXwUmGOdUTZsoNZdNAAjzq2okwOjtOqMCkKfw@mail.gmail.com>
 <CAPXBsRDhQaHXB=JgxC4OMTX8-zQdtEsF2rUsWRK6VRRn6j9i9w@mail.gmail.com>
From: Benjamin Mahler <benjamin.mahler@gmail.com>
Date: Wed, 24 Apr 2013 12:38:45 -0700
Message-ID: 
 <CA+8RcoTY_2xC0eaa7b9qRYbn5Okp3QFZNoWOxijuZAJys58+=w@mail.gmail.com>
Subject: Re: help about support/post-review tools
To: "mesos-dev@incubator.apache.org" <mesos-dev@incubator.apache.org>
Content-Type: multipart/alternative; boundary=bcaec502d5046a91f304db2074dc

--bcaec502d5046a91f304db2074dc
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: quoted-printable

Would love to hear a litte more about how you're using mesos!

Are you writing your own framework or have you been using the Hadoop
framework exclusively? Are you using other third-party frameworks?

Ben


On Tue, Apr 23, 2013 at 7:42 PM, =CD=F5=B9=FA=B6=B0 <wanggd04@gmail.com> wr=
ote:

> Hi Ben,
>
> Thanks a lot. I didn't notice the wrong patch in my second post-review. I
> did 2 commits. Sorry about that.
>
> My team is going to use mesos to deploy our service. And I hope to learn
> more details about Mesos.   :)
>
> Guodong
>
>
> On Wed, Apr 24, 2013 at 1:47 AM, Benjamin Mahler
> <benjamin.mahler@gmail.com>wrote:
>
> > Hey Guodong, I'm going to get this submitted for you, thanks for the
> patch!
> > To make a commit you would need committer access to the project,
> something
> > we will definitely be considering as you help out and contribute furthe=
r!
> >
> > I looked at your diff and it looked like you made two commits? With
> > post-reviews, there is a 1:1 commit:review ratio, so ReviewBoard shows
> your
> > patch only having the second commit:
> >
> > diff --git
> > a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
> > b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
> > index
> >
> >
> 3074bebee3ea4b907b3e24541490cd0d80dcd3e1..afe401f5265e3d9494af7eace42eec4=
5943184a3
> > 100644
> > --- a/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.jav=
a
> > +++ b/hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.jav=
a
> > @@ -224,6 +224,7 @@ public class MesosScheduler extends TaskScheduler
> > implements Scheduler {
> >      // Let the underlying task scheduler do the actual task scheduling=
.
> >      List<Task> tasks =3D taskScheduler.assignTasks(taskTracker);
> >
> > +    // The Hadoop Fair Scheduler is known to return null.
> >      if (tasks !=3D null) {
> >        // Keep track of which TaskTracker contains which tasks.
> >        for (Task task : tasks) {
> >
> > In the future, we use 'git commit --amend' when looking to update an
> > existing review. Interactive rebasing also works when your commit is
> buried
> > in history.
> >
> > But don't worry about it this time! I'll fix this up manually :)
> >
> >
> > On Mon, Apr 22, 2013 at 8:21 PM, =CD=F5=B9=FA=B6=B0 <wanggd04@gmail.com=
> wrote:
> >
> > > BTW: how can I submit my code to the remote repo?
> > >
> > > I see you guys use git-svn, but I use git to pull the repo out. Is it
> Ok
> > to
> > > merge my branch to trunk and push my commit to remote repo?
> > >
> > > Thanks.
> > >
> > > Guodong
> > >
> > >
> > > On Tue, Apr 23, 2013 at 11:03 AM, Vinod Kone <vinodkone@gmail.com>
> > wrote:
> > >
> > > > also, it should be safe to manually delete the bad "Review: ...."
> line
> > > from
> > > > your log message.
> > > >
> > > >
> > > > On Mon, Apr 22, 2013 at 8:00 PM, Benjamin Mahler
> > > > <benjamin.mahler@gmail.com>wrote:
> > > >
> > > > > That definitely looks like a bug! It looks like your version of
> > > > post-review
> > > > > might have different output than the version we typically use. Wh=
at
> > > > version
> > > > > of post-review are you running?
> > > > >
> > > > > Here is an expected git log message:
> > > > >
> > > > > commit 741d67a65713a349450165d5f6cc9f916e04814d
> > > > > Author: Benjamin Mahler <bmahler@twitter.com>
> > > > > Date:   Mon Apr 15 16:10:44 2013 -0700
> > > > >
> > > > >     Removed the hostname:port slave map from the Master.
> > > > >
> > > > >     Review: https://reviews.apache.org/r/10534
> > > > >
> > > > >
> > > > > On Mon, Apr 22, 2013 at 7:52 PM, =CD=F5=B9=FA=B6=B0 <wanggd04@gma=
il.com> wrote:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > I am using support/post-review.py to submit my review. But the
> git
> > > log
> > > > of
> > > > > > my commit seems wrong. I don't know the reason. Now, I can not
> > update
> > > > my
> > > > > > review request with this tool, since it can not parse the corre=
ct
> > > > > > review-request-id from git log.
> > > > > >
> > > > > > The latest 2 commits of my branch is like the following.
> > > > > >
> > > > > > Author: guodong wang <wanggd04@gmail.com>
> > > > > > Date:   Tue Apr 23 10:16:39 2013 +0800
> > > > > >
> > > > > >     add some comments
> > > > > >
> > > > > > commit a688741ae523abb2d83496daa6eae84809d2f2ad
> > > > > > Author: guodong wang <wanggd04@gmail.com>
> > > > > > Date:   Mon Apr 22 10:41:15 2013 +0800
> > > > > >
> > > > > >     fix NullPointerException in MesosScheduler when using
> > > fairscheduler
> > > > > as
> > > > > >     the underlying scheduler
> > > > > >
> > > > > >     Review: Created new window in existing browser session.
> > > > > >
> > > > > > I think the green line is not the right log, Is it possible tha=
t
> > > > > > support/post-review.py generated the wrong Review information ?
> > > > > >
> > > > > > I think I can modify the git log manually to bypass this proble=
m.
> > But
> > > > > still
> > > > > > want to know the reason of it.
> > > > > >
> > > > > > Thanks. :)
> > > > > >
> > > > > > Guodong
> > > > > >
> > > > >
> > > >
> > >
> >
>

--bcaec502d5046a91f304db2074dc--