Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E242DF403 for ; Tue, 30 Apr 2013 18:11:32 +0000 (UTC) Received: (qmail 32701 invoked by uid 500); 30 Apr 2013 18:11:32 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 32679 invoked by uid 500); 30 Apr 2013 18:11:32 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 32667 invoked by uid 99); 30 Apr 2013 18:11:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2013 18:11:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46EF21C9183; Tue, 30 Apr 2013 18:11:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0117130358105169652==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed slave to use Bytes version of memory and disk. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Tue, 30 Apr 2013 18:11:29 -0000 Message-ID: <20130430181129.17260.68107@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10814/ X-Sender: "Vinod Kone" References: <20130429015438.17258.26399@reviews.apache.org> In-Reply-To: <20130429015438.17258.26399@reviews.apache.org> Reply-To: "Vinod Kone" --===============0117130358105169652== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 29, 2013, 1:54 a.m., Ben Mahler wrote: > > src/slave/constants.cpp, line 36 > > > > > > Gigabytes(1) math is hard. > On April 29, 2013, 1:54 a.m., Ben Mahler wrote: > > src/tests/resources_tests.cpp, line 69 > > > > > > Would be nice to change the memory strings to use the size suffixes= , Bytes will already parse it! :) > > = > > e.g. mem:1024MB agreed. not going to do it in this review though. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10814/#review19834 ----------------------------------------------------------- On April 27, 2013, 2:52 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10814/ > ----------------------------------------------------------- > = > (Updated April 27, 2013, 2:52 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > See summary > = > = > Diffs > ----- > = > src/common/resources.hpp e15c2d209b877f1f2cf757bfc1b055c5148cb080 = > src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff = > src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a = > src/slave/slave.hpp f9d9c2b32983700fb09b266a0abf2a396174ae05 = > src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 = > src/tests/resources_tests.cpp 684379f60e9af2dd4a4c75c1f121e253c4c13270 = > = > Diff: https://reviews.apache.org/r/10814/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============0117130358105169652==--