Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 734C21042C for ; Mon, 29 Apr 2013 22:53:28 +0000 (UTC) Received: (qmail 10283 invoked by uid 500); 29 Apr 2013 22:53:28 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 10251 invoked by uid 500); 29 Apr 2013 22:53:28 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 10239 invoked by uid 99); 29 Apr 2013 22:53:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2013 22:53:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D30A61C9467; Mon, 29 Apr 2013 22:53:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6688142475218646740==" MIME-Version: 1.0 Subject: Re: Review Request: Send NoMasterDetectedMessage on session timeout to non-contending detectors. Added a disconnected slave map to the master to track disconnected slaves, in order to disallow slave re-registration after a network partition. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Mon, 29 Apr 2013 22:53:24 -0000 Message-ID: <20130429225324.17260.14483@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10172/ X-Sender: "Benjamin Hindman" References: <20130424235535.22503.79204@reviews.apache.org> In-Reply-To: <20130424235535.22503.79204@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============6688142475218646740== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10172/#review19906 ----------------------------------------------------------- Ship it! src/master/master.hpp Why are you calling these *PIDs? - Benjamin Hindman On April 24, 2013, 11:55 p.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10172/ > ----------------------------------------------------------- > = > (Updated April 24, 2013, 11:55 p.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > See above. This is a fix of MESOS-305. > = > This also fixes MESOS-362. > = > = > This addresses bugs MESOS-305 and MESOS-362. > https://issues.apache.org/jira/browse/MESOS-305 > https://issues.apache.org/jira/browse/MESOS-362 > = > = > Diffs > ----- > = > src/detector/detector.cpp 7a8355162d543e017505dd58efd2d7bf96f99623 = > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed = > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 = > src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 = > src/tests/fault_tolerance_tests.cpp d3476f7f5d1b7e2ed45385f5145eaccd6c1= 14d21 = > src/tests/master_detector_tests.cpp b042d6ffb0c2e58c6c338de2b2534fc6b63= f5f08 = > src/tests/zookeeper_tests.cpp 125b16566d5cd59732fef67d80617724ff71433b = > = > Diff: https://reviews.apache.org/r/10172/diff/ > = > = > Testing > ------- > = > make check > = > Added tests for the partitioned slave re-registration. > ./bin/mesos-tests.sh --gtest_filter=3D"FaultToleranceTest.PartitionedSlav= eReregistration" --verbose --gtest_break_on_failure --gtest_repeat=3D3000 > = > Ran into MESOS-406, but otherwise no issues. > = > Will be adding ZK master detector tests shortly to test that the NoMaster= DetectedMessages are being sent. > = > = > Thanks, > = > Ben Mahler > = > --===============6688142475218646740==--