Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 755C1F3CF for ; Mon, 29 Apr 2013 21:49:39 +0000 (UTC) Received: (qmail 21032 invoked by uid 500); 29 Apr 2013 21:49:39 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 20951 invoked by uid 500); 29 Apr 2013 21:49:39 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 20939 invoked by uid 99); 29 Apr 2013 21:49:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Apr 2013 21:49:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A96621C9462; Mon, 29 Apr 2013 21:49:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3217754211260674005==" MIME-Version: 1.0 Subject: Re: Review Request: Added linux /proc utilities in stout. From: "Ben Mahler" To: "Jiang Yan Xu" , "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Mon, 29 Apr 2013 21:49:35 -0000 Message-ID: <20130429214935.17260.44563@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10809/ X-Sender: "Ben Mahler" References: <20130429174506.17258.90967@reviews.apache.org> In-Reply-To: <20130429174506.17258.90967@reviews.apache.org> Reply-To: "Ben Mahler" --===============3217754211260674005== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 29, 2013, 5:45 p.m., Benjamin Hindman wrote: > > third_party/libprocess/third_party/stout/configure.ac, line 15 > > > > > > Don't want to derail this review, but is there a clean way to just = use target_os in Makefile.am? After reading one of your TODOs, I had searched but to no avail. It seems m= ost people use ${target_os} in configure.ac + AM_CONDITIONAL to pump it int= o the makefile. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10809/#review19869 ----------------------------------------------------------- On April 27, 2013, 12:54 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10809/ > ----------------------------------------------------------- > = > (Updated April 27, 2013, 12:54 a.m.) > = > = > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu. > = > = > Description > ------- > = > Part 1 of moving src/linux/proc.{cpp,hpp} into stout. > = > This was a copy from src/linux/proc.{cpp,hpp}. > = > = > Diffs > ----- > = > third_party/libprocess/third_party/stout/Makefile.am 2f5116f263bde00a5a= 324fbb3403b5b7514b1a1a = > third_party/libprocess/third_party/stout/configure.ac 86e1ff369bdcf1056= bf2ce7606aa3c910e699173 = > third_party/libprocess/third_party/stout/include/stout/os.hpp 4d5169350= 4f15236c131600737d0b6ddb6a1a819 = > third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb= 182cef4ecbf10fc3aa6c6e6c076f1ac46 = > third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREAT= ION = > = > Diff: https://reviews.apache.org/r/10809/diff/ > = > = > Testing > ------- > = > OSX and Linux: make check > = > = > Thanks, > = > Ben Mahler > = > --===============3217754211260674005==--