Return-Path: 
 <mesos-dev-return-8029-apmail-incubator-mesos-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A1D6FFDD2
	for <apmail-incubator-mesos-dev-archive@minotaur.apache.org>;
 Fri, 26 Apr 2013 22:08:49 +0000 (UTC)
Received: (qmail 45254 invoked by uid 500); 26 Apr 2013 22:08:49 -0000
Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org
Received: (qmail 45225 invoked by uid 500); 26 Apr 2013 22:08:49 -0000
Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mesos-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:mesos-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:mesos-dev@incubator.apache.org>
List-Id: <mesos-dev.incubator.apache.org>
Reply-To: mesos-dev@incubator.apache.org
Delivered-To: mailing list mesos-dev@incubator.apache.org
Received: (qmail 45212 invoked by uid 99); 26 Apr 2013 22:08:49 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Apr 2013 22:08:49 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id A25C91C924B;
	Fri, 26 Apr 2013 22:08:45 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1003641459275456357=="
MIME-Version: 1.0
Subject: Re: Review Request: Moved proc::alive function to os::alive in os.hpp
 and
 improved its documentation. (libstout)
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "Jiang Yan Xu" <yan@jxu.me>, "mesos" <mesos-dev@incubator.apache.org>
Date: Fri, 26 Apr 2013 22:08:45 -0000
Message-ID: <20130426220845.22548.62799@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/10745/
X-Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20130426195150.22503.83375@reviews.apache.org>
In-Reply-To: <20130426195150.22503.83375@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============1003641459275456357==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10745/#review19809
-----------------------------------------------------------


Can you add the relevant TODOs to use /proc for more reliable os::alive che=
cking on linux?


third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/10745/#comment40858>

    2 can be verified, but not 1? Is that why this function does not check =
these?



third_party/libprocess/third_party/stout/include/stout/os.hpp
<https://reviews.apache.org/r/10745/#comment40859>

    s/Try<bool>::error/Error/
    =

    Be sure to include <stout/error.hpp>



third_party/libprocess/third_party/stout/include/stout/proc.hpp
<https://reviews.apache.org/r/10745/#comment40856>

    You can make a TODO for me here, as I'm currently working on this :)
    =

    Also, it will be for /proc utilities, not for process utilities.


- Ben Mahler


On April 26, 2013, 7:51 p.m., Jiang Yan Xu wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10745/
> -----------------------------------------------------------
> =

> (Updated April 26, 2013, 7:51 p.m.)
> =

> =

> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> =

> =

> Description
> -------
> =

> See summary.
> =

> =

> Diffs
> -----
> =

>   src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 =

>   third_party/libprocess/third_party/stout/include/stout/os.hpp 4d5169350=
4f15236c131600737d0b6ddb6a1a819 =

>   third_party/libprocess/third_party/stout/include/stout/proc.hpp 19000eb=
182cef4ecbf10fc3aa6c6e6c076f1ac46 =

> =

> Diff: https://reviews.apache.org/r/10745/diff/
> =

> =

> Testing
> -------
> =

> N/A
> =

> =

> Thanks,
> =

> Jiang Yan Xu
> =

>


--===============1003641459275456357==--