Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41B80F81E for ; Fri, 19 Apr 2013 18:54:42 +0000 (UTC) Received: (qmail 85044 invoked by uid 500); 19 Apr 2013 18:54:42 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 85022 invoked by uid 500); 19 Apr 2013 18:54:41 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 85009 invoked by uid 99); 19 Apr 2013 18:54:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Apr 2013 18:54:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B6371C8B1E; Fri, 19 Apr 2013 18:54:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4310918720782939359==" MIME-Version: 1.0 Subject: Re: Review Request: Removed the hostname:port slave maps from the Master. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Fri, 19 Apr 2013 18:54:39 -0000 Message-ID: <20130419185439.15138.86562@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10534/ X-Sender: "Ben Mahler" References: <20130416185030.4546.30389@reviews.apache.org> In-Reply-To: <20130416185030.4546.30389@reviews.apache.org> Reply-To: "Ben Mahler" --===============4310918720782939359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 16, 2013, 6:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1780 > > > > > > I wonder if we should even allow a deactivated slave to register? T= houghts? This was incorrectly based on the slave id, I've changed this to be keyed o= n the UPID of the slave. > On April 16, 2013, 6:50 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1957 > > > > > > I know this code preceded you, but what is the intention behind add= this slave to deactivated? > > = > > Can a slave be removed even when it is not deactivated? > > If no, looks like you already insert it in Master::deactivate()? removeSlave is called from: deactivateSlave() // Slave is not responding. unregisterSlave() // Slave asked to unregister. exited() // When the slave exits and is not checkpointing. Deactivating in all cases above denies re-registration until another regist= ration takes place. Meaning whenever the master removes a slave, that slave= cannot re-register without registering with the master first. Sound good? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10534/#review19269 ----------------------------------------------------------- On April 16, 2013, 12:58 a.m., Ben Mahler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10534/ > ----------------------------------------------------------- > = > (Updated April 16, 2013, 12:58 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Vinod Kone. > = > = > Description > ------- > = > This simplifies the master state. > = > = > Diffs > ----- > = > src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed = > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 = > src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c = > src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815e= a16c0fa1 = > src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104ed= df8 = > = > Diff: https://reviews.apache.org/r/10534/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Ben Mahler > = > --===============4310918720782939359==--