Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CB5310992 for ; Thu, 18 Apr 2013 01:18:16 +0000 (UTC) Received: (qmail 16358 invoked by uid 500); 18 Apr 2013 01:18:15 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 16324 invoked by uid 500); 18 Apr 2013 01:18:15 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 16314 invoked by uid 99); 18 Apr 2013 01:18:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Apr 2013 01:18:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0AEAC1C8910; Thu, 18 Apr 2013 01:18:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6148766290148343576==" MIME-Version: 1.0 Subject: Re: Review Request: Simplify os::hostname() in libstout. From: "Brenden Matthews" To: "Vinod Kone" , "mesos" , "Brenden Matthews" Date: Thu, 18 Apr 2013 01:18:13 -0000 Message-ID: <20130418011813.4549.14351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brenden Matthews" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10345/ X-Sender: "Brenden Matthews" References: <20130408211959.13837.62599@reviews.apache.org> In-Reply-To: <20130408211959.13837.62599@reviews.apache.org> Reply-To: "Brenden Matthews" --===============6148766290148343576== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10345/ ----------------------------------------------------------- (Updated April 18, 2013, 1:18 a.m.) Review request for mesos. Description ------- This patch simplifies os::hostname() in libstout. The call to os::hostname= () would take the result of `gethostname()' and then do a DNS lookup on the= result (presumably to ensure the hosts file is set correctly). This patch= drops the DNS lookup. Diffs (updated) ----- third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693 = Diff: https://reviews.apache.org/r/10345/diff/ Testing ------- Works on our production Hadoop cluster at airbnb. Thanks, Brenden Matthews --===============6148766290148343576==--