Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 318F8F4BC for ; Wed, 17 Apr 2013 06:41:34 +0000 (UTC) Received: (qmail 39654 invoked by uid 500); 17 Apr 2013 06:41:34 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 39619 invoked by uid 500); 17 Apr 2013 06:41:33 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 39608 invoked by uid 99); 17 Apr 2013 06:41:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Apr 2013 06:41:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 355141C8883; Wed, 17 Apr 2013 06:41:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7207095222150130269==" MIME-Version: 1.0 Subject: Re: Review Request: Fixed slave to properly schedule/unschedule top level executor directories for garbage collection. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Wed, 17 Apr 2013 06:41:31 -0000 Message-ID: <20130417064131.4549.99318@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10413/ X-Sender: "Vinod Kone" References: <20130416014544.4546.25140@reviews.apache.org> In-Reply-To: <20130416014544.4546.25140@reviews.apache.org> Reply-To: "Vinod Kone" --===============7207095222150130269== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10413/ ----------------------------------------------------------- (Updated April 17, 2013, 6:41 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- comments and rebase. no need for review. Description ------- This is what I have so far. We need to fix the TODOs inside runTask() before we can call it complete. Diffs (updated) ----- src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 = src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa = src/tests/gc_tests.cpp 872faa74d7a4b71ea4e89d73f450b24c5031e876 = Diff: https://reviews.apache.org/r/10413/diff/ Testing ------- sudo ./bin/mesos-tests.sh --verbose --gtest_filter=3D*GarbageCollectorInteg= rationTest.Unschedule* --gtest_repeat=3D1000 Thanks, Vinod Kone --===============7207095222150130269==--