Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D1A4FD7F for ; Tue, 16 Apr 2013 01:39:33 +0000 (UTC) Received: (qmail 43543 invoked by uid 500); 16 Apr 2013 01:39:33 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 43513 invoked by uid 500); 16 Apr 2013 01:39:33 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 43501 invoked by uid 99); 16 Apr 2013 01:39:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 01:39:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 13B8C1C8860; Tue, 16 Apr 2013 01:39:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6499548233086526720==" MIME-Version: 1.0 Subject: Re: Review Request: Added states to Slave struct. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Tue, 16 Apr 2013 01:39:29 -0000 Message-ID: <20130416013929.4546.59348@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/10268/ X-Sender: "Vinod Kone" References: <20130415192219.4547.19368@reviews.apache.org> In-Reply-To: <20130415192219.4547.19368@reviews.apache.org> Reply-To: "Vinod Kone" --===============6499548233086526720== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 556 > > > > > > Since this sets the trend, do we always want to use braces, or only= when necessary? Do you see any danger of omitting them when not needed? > > = > > I think it would be nice to eliminate all the extra lines needed fo= r the closing braces, if possible. Sure. I hated those braces too. I'm gonna fix it to use braces only when ne= cessary. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 590 > > > > > > Ditto for a TODO to unsubscribe for master detection upon terminati= on? > > = > > Or is there a reason we might want to be notified of new masters du= ring termination? Not really. Added a TODO. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1307 > > > > > > no return? thank you. > On April 15, 2013, 7:22 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1310 > > > > > > else if? We allow executors to register if the slave is running/disconnected. Were y= ou expecting something else? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10268/#review19212 ----------------------------------------------------------- On April 15, 2013, 6:04 a.m., Vinod Kone wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10268/ > ----------------------------------------------------------- > = > (Updated April 15, 2013, 6:04 a.m.) > = > = > Review request for mesos, Benjamin Hindman and Ben Mahler. > = > = > Description > ------- > = > See summary. > = > = > Diffs > ----- > = > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 = > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa = > = > Diff: https://reviews.apache.org/r/10268/diff/ > = > = > Testing > ------- > = > make check > = > = > Thanks, > = > Vinod Kone > = > --===============6499548233086526720==--