Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============5454497663792304762=="
MIME-Version: 1.0
Subject: Re: Review Request: Hadoop changes; see below.
From: "Brenden Matthews" <brenden@diddyinc.com>
To: "Vinod Kone" <vinodkone@gmail.com>,
 "Ben Mahler" <benjamin.mahler@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>,
 "Brenden Matthews" <brenden@diddyinc.com>
Date: Sat, 13 Apr 2013 03:13:58 -0000
Message-ID: <20130413031358.13808.57476@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Brenden Matthews" <noreply@reviews.apache.org>
References: <20130408215546.13808.1517@reviews.apache.org>
In-Reply-To: <20130408215546.13808.1517@reviews.apache.org>
Reply-To: "Brenden Matthews" <brenden@diddyinc.com>

--===============5454497663792304762==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On April 8, 2013, 9:55 p.m., Vinod Kone wrote:
> >
> =

> Ben Mahler wrote:
>     Hey Brenden, will you be updating this review based on the comments?
> =

> Brenden Matthews wrote:
>     Yes, I'll try and finish it up this afternoon.
> =

> Vinod Kone wrote:
>     Cool. Make sure to rebase off the latest trunk, to get the latest had=
oop fixes.
> =

> Ben Mahler wrote:
>     Hey Brenden, I'm happy to give this a review for you, can you first u=
pdate the issues Vinod has raised below? (By either marked them as 'Fixed' =
or 'Dropped'?)
> =

> Brenden Matthews wrote:
>     I can't figure out how to use Review Board. When I click "Fixed" or "=
Drop" nothing happens.

Err nevermind.  Apparently that worked.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10346/#review18797
-----------------------------------------------------------


On April 9, 2013, 10:36 p.m., Brenden Matthews wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10346/
> -----------------------------------------------------------
> =

> (Updated April 9, 2013, 10:36 p.m.)
> =

> =

> Review request for mesos.
> =

> =

> Description
> -------
> =

>     - Added CDH4.2.0 support to TUTORIAL.sh
>     - Fixed Hadoop dist extraction in launcher
>     - Add pre/post packaging hooks to TUTORIAL.sh
>     - Don't run the jobtracker at the end by default if ${SKIP_TESTS}
>       defined
> =

> =

> Diffs
> -----
> =

>   hadoop/Makefile.am bd8919a =

>   hadoop/TUTORIAL.sh f3f3d64 =

>   hadoop/hadoop-0.20.2-cdh3u3_hadoop-env.sh.patch fb8b06b =

>   hadoop/hadoop-0.20.205.0_hadoop-env.sh.patch 8f67ff9 =

>   hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch 6d31578 =

>   hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch PRE-CREATION =

>   hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch PRE-CREATION =

>   src/launcher/launcher.cpp bc50c5f =

> =

> Diff: https://reviews.apache.org/r/10346/diff/
> =

> =

> Testing
> -------
> =

> Works in production on Hadoop at airbnb.
> =

> =

> Thanks,
> =

> Brenden Matthews
> =

>


--===============5454497663792304762==--