Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============0867321638976242731=="
MIME-Version: 1.0
Subject: Re: Review Request: Fixed Allocator Test to use DROP_MESSAGE,
 FutureArg,
 moved expectations closer to actions, etc
From: "Thomas Marshall" <twm378@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>
Cc: "Ben Mahler" <benjamin.mahler@gmail.com>,
 "Thomas Marshall" <twm378@gmail.com>,
 "mesos" <mesos-dev@incubator.apache.org>
Date: Wed, 10 Apr 2013 18:36:50 -0000
Message-ID: <20130410183650.13808.56017@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Thomas Marshall" <noreply@reviews.apache.org>
References: <20130407183851.13808.63521@reviews.apache.org>
In-Reply-To: <20130407183851.13808.63521@reviews.apache.org>
Reply-To: "Thomas Marshall" <twm378@gmail.com>

--===============0867321638976242731==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10329/
-----------------------------------------------------------

(Updated April 10, 2013, 6:36 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Updated to Ben's review.

I also changed all of the resourcesChanged expectations to be WillRepeatedl=
y(DoDefault()). This is to make the tests more robust since the number of t=
imes resourcesChanged might get called isn't a hard guarantee depending on =
specifics about the slave and the timing of the test, and its not something=
 that these tests care about anyways.


Description
-------

See summary.

Additionally, I replaced the MockAllocator in DRFAllocatorTest with a regul=
ar Allocator because the expectations were uninteresting, expectations on c=
alls to the allocator are covered in other tests, and it just made the test=
 a lot messier.


Diffs (updated)
-----

  src/tests/allocator_tests.cpp 04a8581 =


Diff: https://reviews.apache.org/r/10329/diff/


Testing
-------

bin/mesos-tests.sh --gtest_filter=3D*AllocatorTest* --gtest_repeat=3D3000 -=
-gtest_break_on_failure


Thanks,

Thomas Marshall


--===============0867321638976242731==--